Inadvertent use of = instead of ==

One useful construct is for example:

char *pBuffer;
if (pBuffer = malloc(100))
{
    // Continue to work here
}

As mentioned before, and downvoted several times now, I might add this is not specially good style, but I have seen it often enough to say it’s useful. I’ve also seen this with new, but it makes more pain in my chest.

Another example, and less controversial, might be:

while (pointer = getNextElement(context))
{
    // Go for it. Use the pointer to the new segment of data.
}

which implies that the function getNextElement() returns NULL when there is no next element so that the loop is exited.

Leave a Comment