increment a count value outside parallel.foreach scope

by

I like to beat dead horses! 🙂

The “lightest” way to increment the count from multiple threads is:

Interlocked.Increment(ref count);

But as others have pointed out: if you’re doing it inside Parallel.ForEach then you’re probably doing something wrong.

I’m suspecting that for some reason you’re using ForEach but you need an index to the item you’re processing (it will never work with Parallel.ForEach). Am I close? Why do you need the count? What sort of VooDoo magic are you trying to do?

UPDATE:

You seem to be safe with the ConcurrentDictionary if your key is the URI and the value is TAnswer. I don’t see a problem as long as you don’t try to use the count to reference elements in your collection.

Finally…

If you need a counter, then use the Parallel.For loop… it safely increments the counter for you.

More Related Contents:

  1. What does a lock statement do under the hood?
  2. How expensive is the lock statement?
  3. Does lock() guarantee acquired in order requested?
  4. What are the differences between various threading synchronization options in C#?
  5. Parallel.ForEach with adding to list
  6. Volatile vs. Interlocked vs. lock
  7. How to abort a Task like aborting a Thread (Thread.Abort method)?
  8. Why should I prefer single ‘await Task.WhenAll’ over multiple awaits?
  9. C# version of java’s synchronized keyword?
  10. No ConcurrentList in .Net 4.0?
  11. Re-entrant locks in C#
  12. Does Parallel.ForEach limit the number of active threads?
  13. Does a locked object stay locked if an exception occurs inside it?
  14. Parallel Sort Algorithm
  15. Limit the number of parallel threads in C#
  16. Monitor vs Mutex in c# [duplicate]
  17. Do I need to lock or mark as volatile when accessing a simple boolean flag in C#?
  18. What’s the least invasive way to read a locked file in C# (perhaps in unsafe mode)?
  19. Parallel.For(): Update variable outside of loop
  20. C# manual lock/unlock
  21. Process files concurrently and asynchronously
  22. Lock (Monitor) internal implementation in .NET
  23. SynchronizationLockException on Monitor.Exit when using await
  24. Is this use of Parallel.ForEach() thread safe?
  25. Simplest way to run three methods in parallel in C#
  26. Parallel doesnt work with Entity Framework
  27. Check if an application is idle for a time period and lock it
  28. How to lock on an integer in C#?
  29. Synchronizing 2 processes using interprocess synchronizations objects – Mutex or AutoResetEvent
  30. Run async method 8 times in parallel

Leave a Comment