cin for an int inputing a char causes Loop that is supposed to check input to go wild

by

When an error occurs when reading from a stream, an error flag gets set and no more reading is possible until you clear the error flags. That’s why you get an infinite loop.

cin.clear(); // clears the error flags
// this line discards all the input waiting in the stream
cin.ignore(std::numeric_limits<std::streamsize>::max(), '\n');

Also, it’s wrong to use the results of input operation if you don’t know whether the read succeeded in the first place. You can’t make assumptions about the value of iAuswahl. That’s one of most often made errors by newbies using streams. Always check if the input operation was ok. This is most easily done by using operator>> in boolean context:

if (cin >> some_obj) {
    // evaluates to true if it succeeded
} else {
    // something went wrong
}

And, my oh my, this line

while (iAuswahl != 1 && iAuswahl != 2 && iAuswahl != 3 && iAuswahl != 4 && iAuswahl != 5 && iAuswahl != 6 && iAuswahl != 7 && iAuswahl != 8 && iAuswahl != 9)

can be just this:

while (iAuswahl < 1 || iAuswahl > 9)

A correct loop could look something like this:

while (true)
{
    if ((cin >> iAuswahl) && (iAuswahl >= 1) && (iAuswahl <= 9)) break;
    std::cout << "error, try again\n";
    cin.clear();
    cin.ignore(std::numeric_limits<std::streamsize>::max(), '\n');
}

More Related Contents:

  1. Convert char array to single int?
  2. Char* combining [closed]
  3. Why when i add number to string it shows random text in c++?
  4. Easiest way to convert int to string in C++
  5. How to convert a std::string to const char* or char*
  6. How do I flush the cin buffer?
  7. Why must a short be converted to an int before arithmetic operations in C and C++?
  8. Is a string literal in С++ created in static memory?
  9. Convert hex string (char []) to int?
  10. Reading and writing binary file
  11. Integer to hex string in C++
  12. getline not asking for input? [duplicate]
  13. Why does stringstream >> change value of target on failure?
  14. if (cin >> x) – Why can you use that condition?
  15. std::cout won’t print
  16. performance of unsigned vs signed integers
  17. What’s the difference between long long and long
  18. Why is modifying a string through a retrieved pointer to its data not allowed?
  19. Multiplication of two integers in C++
  20. Why does this code with ‘1234’ compile in C++?
  21. When does cout flush?
  22. cin >> fails with bigger numbers but works with smaller ones?
  23. What does flushing the buffer mean?
  24. cannot convert ‘const char*’ to ‘LPCWSTR {aka const wchar_t*}’
  25. Why can’t I static_cast between char * and unsigned char *?
  26. What is the simplest way to convert char[] to/from tchar[] in C/C++(ms)?
  27. “cout” and “char address” [duplicate]
  28. How to read in user entered comma separated integers?
  29. Assign a string literal to a char* [duplicate]
  30. C++ concatenate two int arrays into one larger array

Leave a Comment