Is it a bug to pass a single-element array to SendInput?

by

Short answer: Maybe.

Longer answer: It depends.

To see what it depends on, and when this matters, it helps to understand, why SendInput was introduced into the Windows API: For one, it consolidates the keybd_event and mouse_event APIs into a single API call. More importantly, it adds a significant feature that isn’t available to the previous calls. This is called out in the documentation:

The SendInput function inserts the events in the INPUT structures serially into the keyboard or mouse input stream. These events are not interspersed with other keyboard or mouse input events inserted either by the user (with the keyboard or mouse) or by calls to keybd_event, mouse_event, or other calls to SendInput.

In other words: SendInput establishes atomicity of injected input sequences, irrespective of external events outside the control of the calling code.

It is usually important to atomically inject input, when the input consists of a sequence of individual events, like in the question. The code injects a mouse button down followed by a mouse button up in 2 individual calls to SendInput. While the intention is to have a single mouse click event, the implementation allows other input sources to intersperse input. When another input source produces a mouse move event in between the mouse button down and up events, the intended click has turned into a drag-and-drop operation. Instead of selecting a file in File Explorer, that very same code has thrown the file into the Recycle Bin. That clearly constitutes a bug.

Likewise, injecting keyboard input consisting of key combinations generally requires atomicity guarantees. Injecting Ctrl+C requires all four input events to be in a single transaction. Otherwise, a (malicious) input source could synthesize a Ctrl key up event right after the Ctrl key down, leaving the code injecting a C, with a stray Ctrl key up event trailing. That’s probably not what was intended either.

In summary: It is a bug to call SendInput repeatedly, passing 1 as the first argument if the following conditions are true:

  • The input consists of a sequence of individual input events.
  • The input is required to be interpreted as a single unit.

More Related Contents:

  1. Programmable router
  2. Exporting functions from a DLL with dllexport
  3. How can a Win32 process get the pid of its parent?
  4. How to create a resizable CDialog in MFC?
  5. Does Windows 7 restrict folder access as Vista does?
  6. Overlapped I/O on anonymous pipe
  7. What is the difference between the `A` and `W` functions in the Win32 API?
  8. How do I get a list of available serial ports in Win32?
  9. Building libcurl with SSL support on Windows
  10. Removing window border?
  11. Alignment requirements for atomic x86 instructions vs. MS’s InterlockedCompareExchange documentation?
  12. What’s the differences between VirtualAlloc and HeapAlloc?
  13. Win32: full-screen and hiding taskbar
  14. Avoiding UAC but launching an elevated process using a windows service
  15. How to make a keyboard hook global across processes
  16. Are TCP SOCKET handles inheritable?
  17. How do I detect the DLLs required by an application?
  18. Why is ExitProcess necessary under Win32 when you can use a RET?
  19. SendInput() not equal to pressing key manually on keyboard in C++?
  20. Is it possible programmatically add folders to the Windows 10 Quick Access panel in the explorer window?
  21. How to gracefully terminate a process?
  22. Can DPI scaling be enabled/disabled programmatically on a per-session basis?
  23. How do you set the glass blend colour on Windows 10?
  24. Windows 7 SDK installation failure
  25. How do I find position of a Win32 control/window relative to its parent window?
  26. Programmatically prevent Windows screensaver from starting
  27. How do I capture the audio that is being played?
  28. Is there a Windows equivalent of nanosleep?
  29. Capturing a Window that is hidden or minimized
  30. Detect external display being connected or removed under Windows 7

Leave a Comment