Is it good practice to make the constructor throw an exception? [duplicate]

by

Throwing exceptions in a constructor is not bad practice. In fact, it is the only reasonable way for a constructor to indicate that there is a problem; e.g. that the parameters are invalid.

I also think that throwing checked exceptions can be OK1, assuming that the checked exception is 1) declared, 2) specific to the problem you are reporting, and 3) it is reasonable to expect the caller to deal with a checked exception for this2.

However explicitly declaring or throwing java.lang.Exception is almost always bad practice.

You should pick an exception class that matches the exceptional condition that has occurred. If you throw Exception it is difficult for the caller to separate this exception from any number of other possible declared and undeclared exceptions. This makes error recovery difficult, and if the caller chooses to propagate the Exception, the problem just spreads.

1 – Some people may disagree, but IMO there is no substantive difference between this case and the case of throwing exceptions in methods. The standard checked vs unchecked advice applies equally to both cases.
2 – For example, the existing FileInputStream constructors will throw FileNotFoundException if you try to open a file that does not exist. Assuming that it is reasonable for FileNotFoundException to be a checked exception3, then the constructor is the most appropriate place for that exception to be thrown. If we threw the FileNotFoundException the first time that (say) a read or write call was made, that is liable to make application logic more complicated.
3 – Given that this is one of the motivating examples for checked exceptions, if you don’t accept this you are basically saying that all exceptions should be unchecked. That is not practical … if you are going to use Java.

Someone suggested using assert for checking arguments. The problem with this is that checking of assert assertions can be turned on and off via a JVM command-line setting. Using assertions to check internal invariants is OK, but using them to implement argument checking that is specified in your javadoc is not a good idea … because it means your method will only strictly implement the specification when assertion checking is enabled.

The second problem with assert is that if an assertion fails, then AssertionError will be thrown, and received wisdom is that it is a bad idea to attempt to catch Error and any of its subtypes.

More Related Contents:

  1. Can constructors throw exceptions in Java?
  2. Why use setters in java instead of constructors? [duplicate]
  3. Calling a non-static method with constructors using objects from a different class [duplicate]
  4. How can I solve “java.lang.NoClassDefFoundError”?
  5. What are the effects of exceptions on performance in Java?
  6. How to generate exceptions from RepaintManager
  7. Returning from a finally block in Java
  8. ClassNotFoundException com.mysql.jdbc.Driver [duplicate]
  9. Java Constructor Inheritance
  10. Is it unnecessary to put super() in constructor?
  11. How to create custom exceptions in Java? [closed]
  12. Given final block not properly padded
  13. Calling method from constructor
  14. Null check chain vs catching NullPointerException
  15. Can a constructor in Java be private?
  16. Why does division by zero with floating point (or double precision) numbers not throw java.lang.ArithmeticException: / by zero in Java
  17. How to initialize HashSet values by construction?
  18. When should an IllegalArgumentException be thrown?
  19. How does `this` reference to an outer class escape through publishing inner class instance?
  20. In a Java 7 multicatch block what is the type of the caught exception?
  21. Java Error: The constructor is undefined
  22. What does the ‘new’ keyword actually do in Java, and should I avoid creating new objects?
  23. Why can’t enum constructors be protected or public in Java?
  24. Android exception handling best practice?
  25. What is meant by abstract=”true” in spring?
  26. Should java try blocks be scoped as tightly as possible?
  27. Should methods that throw RuntimeException indicate it in method signature?
  28. Unable to run JUnit test with PowerMockRunner
  29. maximum size of java class / exception table
  30. Difference between a no-arg constructor and a default constructor in Java

Leave a Comment