Is it worth setting pointers to NULL in a destructor?

by

Several answer mention that it might be worthwhile to do this in a DEBUG build to aid in debugging.

Do not do this.

You’ll just potentially help hide a problem in a debug build that isn’t hidden in your release builds that you actually give to customers (which is the opposite effect that your debug builds should have).

If you’re going to ‘clear’ the pointer in the dtor, a different idiom would be better – set the pointer to a known bad pointer value. That way if there is a dangling reference to the object somewhere that ultimately tries to use the pointer, you’ll get a diagnosable crash instead of the buggy code avoiding use of the pointer because it notices that it’s NULL.

Say that doSomething() looked like:

void doSomething()
{
    if (bar) bar->doSomething();
}

Then setting bar to NULL has just helped hide a bug if there was a dangling reference to a deleted Foo object that called Foo::doSomething().

If your pointer clean up looked like:

~Foo()
{
    delete bar;
    if (DEBUG) bar = (bar_type*)(long_ptr)(0xDEADBEEF);
}

You might have a better chance of catching the bug (though just leaving bar alone would probably have a similar effect).

Now if anything has a dangling reference to the Foo object that’s been deleted, any use of bar will not avoid referencing it due to a NULL check – it’ll happily try to use the pointer and you’ll get a crash that you can fix instead of nothing bad happening in debug builds, but the dangling reference still being used (to ill effect) in your customer’s release builds.

When you’re compiling in debug mode, chances are pretty good that the debug heap manager will already be doing this for you anyway (at least MSVC’s debug runtime heap manager will overwrite the freed memory with 0xDD to indicate the memory is dead/freed).

The key thing is that if you’re using raw pointers as class members, don’t set the pointers to NULL when the dtor runs.

This rule might also apply to other raw pointers, but that depends on exactly how the pointer is used.

More Related Contents:

  1. how to change to c code while using for loop and array
  2. How do I set a global #define in my C++ project? [closed]
  3. in c++ when i declare an integer variable int a = 200L or int a = 200F or int a = 200U, It allows. How does this happen?
  4. Why it is so ? And It is without you explicitly do casting [duplicate]
  5. Information Hiding VS Encapsulation
  6. System where 1 byte != 8 bit? [duplicate]
  7. Namespace + functions versus static methods on a class
  8. GCC and Precompiled Headers
  9. Is it legal to recurse into main() in C++? [duplicate]
  10. Why class data members can’t be initialized by direct initialization syntax?
  11. Web browser control emulation issue (FEATURE_BROWSER_EMULATION)
  12. Why does C++ allow unnamed function parameters?
  13. Why is it OK to return a ‘vector’ from a function?
  14. Initialize parent’s protected members with initialization list (C++)
  15. ampersand (&) at the end of variable etc
  16. Declare large array on Stack
  17. DLL Load Library – Error Code 126
  18. How to set the stacksize with C++11 std::thread
  19. CUDA and Classes
  20. What is wrong with using inline functions?
  21. How to pass a vector of strings to execv
  22. What should I know about Structured Exceptions (SEH) in C++?
  23. When should I write the keyword ‘static’ before a non-member function?
  24. Profiler for Visual Studio 2008, C++?
  25. Win32 – read from stdin with timeout
  26. Template default arguments
  27. Removing watermark out of an image using OpenCV
  28. Extern functions in C vs C++
  29. Can we apply content not explicitly cited from the normative references to the C++ standard?
  30. AVX2: Computing dot product of 512 float arrays

Leave a Comment