Is typedef’ing a pointer type considered bad practice? [duplicate]

by

In general, it’s a bad practice. The significant problem is that it does not play well with const:

typedef type_t *TYPE;
extern void set_type(TYPE t);

void foo(const TYPE mytype) {
  set_type(mytype);  // Error expected, but in fact compiles
}

In order for the author of foo() to express what they really mean, the library that provides TYPE must also provide CONST_TYPE:

typedef const type_t *CONST_TYPE;

so that foo() can have the signature void foo(CONST_TYPE mytype), and at this point we have descended into farce.

Hence a rule of thumb:

Make typedefs of structs (particularly incomplete structs), not pointers to those structs.

If the definition of the underlying struct is not to be publicly available (which is often laudable), then that encapsulation should be supplied by the struct being incomplete, rather than by inconvenient typedefs:

struct type_t;
typedef struct type_t type_t;

void set_type(type_t *);
int get_type_field(const type_t *);

More Related Contents:

  1. C typedef of pointer to structure
  2. In C, is it good form to use typedef for a pointer?
  3. Unit testing for a function (tolower) using pointers
  4. Convert double * to double [9] in C [closed]
  5. C pointer to another struct
  6. Is an array name a pointer?
  7. Returning an array using C
  8. Typedef function pointer?
  9. Arrow operator (->) usage in C
  10. Why use double indirection? or Why use pointers to pointers?
  11. printf(“%p”) and casting to (void *)
  12. Exceptions to array decaying into a pointer?
  13. Why do arrays in C decay to pointers?
  14. Tricks to analyse pointer and pointer-to-pointer structures in C?
  15. C: pointer to struct in the struct definition
  16. uint8_t vs unsigned char
  17. Checking if a pointer is allocated memory or not
  18. Pointer/Address difference [duplicate]
  19. Enforce strong type checking in C (type strictness for typedefs)
  20. C++ typedef interpretation of const pointers
  21. how to get hexdump of a structure data
  22. Changing array inside function in C
  23. How to align a pointer in C
  24. C isn’t that hard: void ( *( *f[] ) () ) ()
  25. What’s the difference between array and &array?
  26. When printf is an address of a variable, why use void*?
  27. Pointer expressions: **ptr++, *++*ptr and ++**ptr use
  28. How to create a typedef for function pointers
  29. Can a “container_of” macro ever be strictly-conforming?
  30. Difference between pointer to pointer and pointer to array?

Leave a Comment