JavaScript for loop index strangeness [duplicate]

by

You are having a very common closure problem in the for loop.

Variables enclosed in a closure share the same single environment, so by the time the onclick callback is executed, the loop has run its course and the i variable will be left pointing to the last entry.

You can solve this with even more closures, using a function factory:

function makeOnClickCallback(i) {  
   return function() {  
      alert(i);
      return false;
   };  
} 

var i;

for (i = 0; i < 2; i++) {
    buttons[i].onclick = makeOnClickCallback(i);
}

This can be quite a tricky topic, if you are not familiar with how closures work. You may to check out the following Mozilla article for a brief introduction:

Note: I would also suggest not to use var inside the for loop, because this may trick you in believing that the i variable has block scope, when on the other hand the i variable is just like the buttons variable, scoped within the function.

More Related Contents:

  1. Disable a part of JavaScript code [closed]
  2. adding array elements with for loop JavaScript
  3. Loop through an array in JavaScript
  4. addEventListener vs onclick
  5. onclick or inline script isn’t working in extension
  6. What is the difference between ( for… in ) and ( for… of ) statements?
  7. Show/hide ‘div’ using JavaScript
  8. Calling an asynchronous function within a for loop in JavaScript
  9. Uncaught ReferenceError: function is not defined with onclick
  10. Are loops really faster in reverse?
  11. Get the contents of a table row with a button click
  12. JavaScript Loops: for…in vs for
  13. Adding click event handler to iframe
  14. Onclick javascript to make browser go back to previous page?
  15. Get loop counter/index using for…of syntax in JavaScript
  16. JavaScript loop variable scope
  17. How to completely DISABLE any MOUSE CLICK
  18. Changing button text onclick
  19. Javascript – Dynamically assign onclick event in the loop
  20. javascript for loop counter coming out as string [duplicate]
  21. addEventListener vs onclick
  22. Change CSS properties on click
  23. Loop in Jade (currently known as “Pug”) template engine
  24. Strange behavior in Javascript enhanced for…in loop
  25. Redirect form to different URL based on select option element
  26. Iterating a JavaScript object’s properties using jQuery
  27. Change image source with JavaScript
  28. Attribute onclick=”function()” not functioning as intended?
  29. Calling onclick on a radiobutton list using javascript
  30. Simulating a click in jQuery/JavaScript on a link

Leave a Comment