LINQ OrderBy versus ThenBy

by

You should definitely use ThenBy rather than multiple OrderBy calls.

I would suggest this:

tmp = invoices.InvoiceCollection
              .OrderBy(o => o.InvoiceOwner.LastName)
              .ThenBy(o => o.InvoiceOwner.FirstName)
              .ThenBy(o => o.InvoiceID);

Note how you can use the same name each time. This is also equivalent to:

tmp = from o in invoices.InvoiceCollection
      orderby o.InvoiceOwner.LastName,
              o.InvoiceOwner.FirstName,
              o.InvoiceID
      select o;

If you call OrderBy multiple times, it will effectively reorder the sequence completely three times… so the final call will effectively be the dominant one. You can (in LINQ to Objects) write

foo.OrderBy(x).OrderBy(y).OrderBy(z)

which would be equivalent to

foo.OrderBy(z).ThenBy(y).ThenBy(x)

as the sort order is stable, but you absolutely shouldn’t:

  • It’s hard to read
  • It doesn’t perform well (because it reorders the whole sequence)
  • It may well not work in other providers (e.g. LINQ to SQL)
  • It’s basically not how OrderBy was designed to be used.

The point of OrderBy is to provide the “most important” ordering projection; then use ThenBy (repeatedly) to specify secondary, tertiary etc ordering projections.

Effectively, think of it this way: OrderBy(...).ThenBy(...).ThenBy(...) allows you to build a single composite comparison for any two objects, and then sort the sequence once using that composite comparison. That’s almost certainly what you want.

More Related Contents:

  1. Convert this sql command to c# linq
  2. LINQ equivalent of foreach for IEnumerable
  3. Is it possible to Pivot data using LINQ?
  4. C# LINQ find duplicates in List
  5. What are the benefits of a Deferred Execution in LINQ?
  6. Entity framework linq query Include() multiple children entities
  7. How can I do an OrderBy with a dynamic string parameter?
  8. LINQ to Entities does not recognize the method ‘System.String Format(System.String, System.Object, System.Object)’
  9. LINQ recursion function?
  10. Convert String to Int in EF 4.0
  11. System.LINQ.Dynamic: Select(” new (…)”) into a List (or any other enumerable collection of )
  12. LINQ: Dot Notation vs Query Expression
  13. Learning about LINQ [closed]
  14. Standard Deviation in LINQ
  15. Can LINQ be used in PowerShell?
  16. How To Project a Line Number Into Linq Query Results
  17. Calculate difference from previous item with LINQ
  18. Use LINQ to concatenate multiple rows into single row (CSV property)
  19. LINQ with SQLite (linqtosql)
  20. Linq-to-entities – Include() method not loading
  21. How to create a dynamic LINQ join extension method
  22. PowerShell equivalent of LINQ Any()?
  23. Instantiating a context in LINQ to Entities
  24. conditional include in linq to entities?
  25. Linq To Entities – how to filter on child entities
  26. Expose IQueryable Over WCF Service
  27. Is there a pattern using Linq to dynamically create a filter?
  28. Simple Linq query has duplicated join against same table?
  29. Linq to SQL how to do “where [column] in (list of values)”
  30. LINQ: How to convert the nested hierarchical object to flatten object

Leave a Comment