List and maximum numbers

by

Your first problem is at highest = List[0]. Since List is not guaranteed to have at least one item, you will have an error if List is empty. You should add a check:

def getMax4(List):
    if not List: # or if len(List) == 0:
        return -999
    ...

Another problem is that you define highest as the first item. Why? The first item could possibly be the highest only if it is divisible by four. You should set it to 0 so that even if there are no numbers divisible by four, it will still have the default of 0 that is required in the examples.

The next problem is that you are returning inside the loop. Wait until the loop is done before you try to return.

Once we fix all those, the problem is that -4 is better than 0 even though it is lower. We can simply add a check for not highest (highest is equal to 0). The new code looks like this:

def getMax4(List):
    if not List:
        return -999
    highest = 0
    for num in List:
        if num % 4 == 0 and (num > highest or not highest):
            highest = num
    return highest

More Related Contents:

  1. Why am getting an "elif" syntax error showing invalid syntax in python [closed]
  2. Why doesn’t this python code run infinite times? [closed]
  3. How to optimise my code efficiency to speed up large data file extraction programs?
  4. Accessing class variables from a list comprehension in the class definition
  5. Python 3: UnboundLocalError: local variable referenced before assignment [duplicate]
  6. Should I put #! (shebang) in Python scripts, and what form should it take?
  7. Priority of the logical operators NOT, AND, OR in Python
  8. Python iterator is empty after performing some action on it
  9. List attributes of an object [duplicate]
  10. Image library for Python 3
  11. Unable to set default python version to python3 in ubuntu
  12. How to uninstall a package installed with pip install –user
  13. How to deal with Kivy installing error in Python 3.8?
  14. PermissionError: [WinError 32] The process cannot access the file because it is being used by another process
  15. Removing control characters from a string in python
  16. Why np.hypot and np.subtract.outer very fast compared to vanilla broadcast ? Using Numba for speedup numpy in parallel for distance matrix calculation
  17. How to display an image after a time interval?
  18. Accessing dict_keys element by index in Python3
  19. What does *tuple and **dict mean in Python? [duplicate]
  20. How to change UI in same window using PyQt5?
  21. Creating an Ordered Counter
  22. Will OrderedDict become redundant in Python 3.7?
  23. Why do parentheses in a lambda function cause syntax error on Python 3? [duplicate]
  24. list comprehension filtering – “the set() trap”
  25. Sort a list of tuples depending on two elements [duplicate]
  26. How to replicate array to specific length array
  27. Read .csv file from URL into Python 3.x – _csv.Error: iterator should return strings, not bytes (did you open the file in text mode?)
  28. How to find cube root using Python? [duplicate]
  29. When using cx_Freeze and tkinter I get: “DLL load failed: The specified module could not be found.” (Python 3.5.3)
  30. How do you change the value of one attribute by changing the value of another? (dependent attributes)

Leave a Comment