List on python appending always the same value [duplicate]

by

A simplified example of your code currently to explain more fully why your results are the way they are:

all_items = []
new_item = {}
for i in range(0,5):
    new_item['a'] = i
    new_item['b'] = i

    all_items.append(new_item)
    print new_item
    print hex(id(new_item))  # print memory address of new_item

print all_items

Notice the memory address for your object is the same each time you go through your loop. This means that your object being added is the same, each time. So when you print the final list, you are printing the coordinates of the same object at every location in the loop.

Each time you go through the loop, the values are being updated – imagine you are painting over the same wall every day. The first day, it might be blue. The next day, you repaint the same wall (or object) and then it’s green. The last day you paint it orange and it’s orange – the same wall is always orange now. Your references to the attr object are like saying you have the same wall.

Even though you looked at the wall after painting it, the color changed. But afterwards it is a orange wall – even if you look at it 5 times.

When we make the object as a new object in each iteration, notice two things happen:

  1. the memory address changes
  2. the values persist as unique values

This is similar to painting different walls. After you finish painting the last one, each of the previous walls is still painted the color you first painted it.

You can see this in the following, where each object is created each iteration:

all_items = []
for i in range(0,5):
    new_item = {}
    new_item['a'] = i
    new_item['b'] = i

    all_items.append(new_item)
    print hex(id(new_item))


 print all_items

You can also do in a different way, such as:

all_items = []
for i in range(0,5):
    new_item = {'a': i, 'b': i}
    all_items.append(new_item)
    print hex(id(new_item))    
print all_items

or even in one step:

all_items = []
for i in range(0,5):
    all_items.append({'a': i, 'b': i})

print all_items

Either of the following will therefore work:

attr = {}
attr['height'] = height 
attr['weight'] = weight

men.append(attr)

or:

men.append({'height': height, 'weight': weight})

More Related Contents:

  1. What do ellipsis […] mean in a list?
  2. Why is a list comprehension so much faster than appending to a list?
  3. Insert an element at a specific index in a list and return the updated list
  4. Changing an element in one list changes multiple lists [duplicate]
  5. Getting only element from a single-element list in Python?
  6. 2D list has weird behavor when trying to modify a single value [duplicate]
  7. python filter list of dictionaries based on key value
  8. In Python, why is list[] automatically global?
  9. Print LIST of unicode chars without escape characters
  10. Why python’s list slicing doesn’t produce index out of bound error? [duplicate]
  11. Write and read a list from file
  12. Unexpected IndexError while removing list items [duplicate]
  13. How to apply a function to each sublist of a list in python?
  14. Sort a list with a custom order in Python
  15. sum each value in a list of tuples
  16. flatten list of list through list comprehension
  17. TypeError: unsupported operand type(s) for -: ‘list’ and ‘list’
  18. How to sort list of lists according to length of sublists [duplicate]
  19. Skip elements on a condition based in a list comprehension in python
  20. Converting string to tuple without splitting characters
  21. Python: Finding differences between elements of a list
  22. Calling filter returns [duplicate]
  23. Python Save to file
  24. Redirecting stdout to “nothing” in python
  25. Find an element in a list of tuples
  26. Why can I pass an instance method to multiprocessing.Process, but not a multiprocessing.Pool?
  27. How to convert list of tuples to multiple lists?
  28. Making HTTP HEAD request with urllib2 from Python 2
  29. I want to multiply two columns in a pandas DataFrame and add the result into a new column
  30. What is different between makedirs and mkdir of os?

Leave a Comment