Loop “Forgets” to Remove Some Items [duplicate]

by

You’re modifying the list you’re iterating over, which is bound to result in some unintuitive behavior. Instead, make a copy of the list so you don’t remove elements from what you’re iterating through.

for char in textlist[:]: #shallow copy of the list
    # etc

To clarify the behavior you’re seeing, check this out. Put print char, textlist at the beginning of your (original) loop. You’d expect, perhaps, that this would print out your string vertically, alongside the list, but what you’ll actually get is this:

H ['H', 'e', 'y', ' ', 'l', 'o', 'o', 'k', ' ', 'W', 'o', 'r', 'd', 's', '!']
e ['H', 'e', 'y', ' ', 'l', 'o', 'o', 'k', ' ', 'W', 'o', 'r', 'd', 's', '!']
  ['H', 'y', ' ', 'l', 'o', 'o', 'k', ' ', 'W', 'o', 'r', 'd', 's', '!'] # !
l ['H', 'y', ' ', 'l', 'o', 'o', 'k', ' ', 'W', 'o', 'r', 'd', 's', '!']
o ['H', 'y', ' ', 'l', 'o', 'o', 'k', ' ', 'W', 'o', 'r', 'd', 's', '!']
k ['H', 'y', ' ', 'l', 'o', 'k', ' ', 'W', 'o', 'r', 'd', 's', '!'] # Problem!!
  ['H', 'y', ' ', 'l', 'o', 'k', ' ', 'W', 'o', 'r', 'd', 's', '!']
W ['H', 'y', ' ', 'l', 'o', 'k', ' ', 'W', 'o', 'r', 'd', 's', '!']
o ['H', 'y', ' ', 'l', 'o', 'k', ' ', 'W', 'o', 'r', 'd', 's', '!'] 
d ['H', 'y', ' ', 'l', 'k', ' ', 'W', 'o', 'r', 'd', 's', '!']
s ['H', 'y', ' ', 'l', 'k', ' ', 'W', 'o', 'r', 'd', 's', '!']
! ['H', 'y', ' ', 'l', 'k', ' ', 'W', 'o', 'r', 'd', 's', '!']
Hy lk Words!

So what’s going on? The nice for x in y loop in Python is really just syntactic sugar: it still accesses list elements by index. So when you remove elements from the list while iterating over it, you start skipping values (as you can see above). As a result, you never see the second o in "look"; you skip over it because the index has advanced “past” it when you deleted the previous element. Then, when you get to the o in "Words", you go to remove the first occurrence of 'o', which is the one you skipped before.

As others have mentioned, list comprehensions are probably an even better (cleaner, clearer) way to do this. Make use of the fact that Python strings are iterable:

def remove_vowels(text): # function names should start with verbs! :)
    return ''.join(ch for ch in text if ch.lower() not in 'aeiou')

More Related Contents:

  1. Unable to use convert strings into integers for a for loop
  2. Why is it string.join(list) instead of list.join(string)?
  3. How do I concatenate items in a list to a single string?
  4. How to check if a string is a substring of items in a list of strings?
  5. Split a string by a delimiter in python
  6. What exactly does the .join() method do?
  7. Create nice column output in python
  8. Join a list of items with different types as string in Python
  9. Pandas DataFrame stored list as string: How to convert back to list
  10. Check if string ends with one of the strings from a list
  11. Alphabet range in Python
  12. How do I split a string into a list of characters?
  13. Splitting on last delimiter in Python string?
  14. Joining pairs of elements of a list [duplicate]
  15. How does the max() function work on list of strings in python?
  16. str.startswith with a list of strings to test for
  17. How to split strings inside a list by whitespace characters
  18. Convert string to list. Python [string.split() acting weird]
  19. Why python’s list slicing doesn’t produce index out of bound error? [duplicate]
  20. Converting a string that represents a list, into an actual list object
  21. Python: find closest string (from a list) to another string
  22. How to concatenate (join) items in a list to a single string
  23. How to convert a string with comma-delimited items to a list in Python?
  24. Adding a string to a list using augmented assignment
  25. Column of lists, convert list to string as a new column
  26. Deleting consonants from a string in Python
  27. How does str.startswith really work?
  28. How does str(list) work?
  29. Concatenate elements of a tuple in a list in python [duplicate]
  30. Length of longest word in a list

Leave a Comment