nothing happens when i execute the code. Got my methods right? [closed]

by

If you ever actually try to construct an instance of Rektanglar, you’ll get a stack overflow due to this:

public class Rektanglar extends JPanel {
   Rektanglar r1 = new Rektanglar ();
   ...
}

That code says that in order to create one instance, you need to create another instance… which will create yet another instance, etc.

It’s not at all clear why you’ve got r1 at all, but I strongly suggest you get rid of it…

I also suspect this:

public void Rectangle(int x, int y, int w, int h) {
    X = x;
    Y = y;
    width = w;
    height = h;
}

… is meant to be a constructor, in which case you’d have to write it as:

public Rektanglar(int x, int y, int w, int h) {
    X = x;
    Y = y;
    width = w;
    height = h;
}

Note that the name has to match the name of the class and you don’t specify a return type.

Additionally, I’d suggest that:

  • You make all fields private
  • You compute the perimeter and area from the width and height, rather than keeping them as fields
  • You follow Java naming conventions for your variables (so x and y instead of X and Y).

More Related Contents:

  1. Is Java "pass-by-reference" or "pass-by-value"?
  2. get Index of last Element in list without using lastIndexOf() or any other Java/String- Methods [closed]
  3. Java Questions! About List and Objects
  4. Variable may not of been initialized even though it has been in the method
  5. Java synchronized static methods: lock on object or class
  6. Why does this Java method appear to have two return types?
  7. Why doesn’t Mockito mock static methods?
  8. Converting Integers to Roman Numerals – Java
  9. Should private helper methods be static if they can be static
  10. Set and Get Methods in java?
  11. Advantage of set and get methods vs public variable [duplicate]
  12. How do I intercept a method invocation with standard java features (no AspectJ etc)?
  13. Are there any Java method ordering conventions? [closed]
  14. Return multiple values from a Java method: why no n-tuple objects?
  15. Compiler error : reference to call ambiguous
  16. What does the return keyword do in a void method in Java?
  17. Optional Methods in Java Interface
  18. Can non-static methods modify static variables
  19. What does ‘public static void’ mean in Java?
  20. Java: Sending Multiple Parameters to Method [closed]
  21. How can I create a Java method that accepts a variable number of arguments?
  22. Naming conventions for Java methods that return boolean
  23. Can methods in java be nested and what is the effect? [closed]
  24. method in class cannot be applied to given types
  25. java.lang.NullPointerException with boolean
  26. Can there exist two main methods in a Java program?
  27. Java: How to find if a method is overridden from base class? [duplicate]
  28. Is it possible to find the source for a Java native method?
  29. How to automatically log the entry/exit of methods in Java?
  30. Java – Creating an array of methods

Leave a Comment