Organizationally, where should I put common queries when using Entity Framework Code First?

by

Looks like the repository pattern is solution for everything … Repository is not a silver bullet!

I’m using the repository pattern with EF everyday because when I started my current project several months ago it looked like recommended solution. My conclusions:

  • Repository makes interaction with EF much harder. Just browse questions related to EF tags and you will see what complexities must be handled directly on the context, changetracker, etc.
  • Generic repository is something that works for CRUD operations but not for real DDD scenarios. Once your repository works with aggregate roots (DDD) generic approach fails.
  • Unit testing doesn’t work at all because general idea that you will mock repository and test your upper layer without dependencies to EF and database fails once you expose IQueryable. Linq-to-entities is only subset of Linq-to-objects and mock doesn’t handle referential integrity so many times I saw green unit tests and runtime exceptions. The correct testing approach with EF are integration tests. Mocking repository is only for testing real business logic not related to data access. If you don’t have integration test for your business method accessing or persisting data you didn’t test it.
  • Exposing specialized methods like GetByXXX is just step back. Most of these methods are used only once. You will end with the code similar to repositories used for wrapping stored procedures calls. Many developers like ORM just because they can avoid such rigid architecture.

EF itself already offers repository pattern – DbSet and ObjectSet are repositories and DbContext and ObjectContext are Unit of works. So in my opinion repository pattern is overused. It can be useful in large projects where you need strict layering or in case of placing additional logic to its methods. Using repository just because you want to wrap access to EF is often valueless code and just additional layer of complexity.

You can in the same way create reusable methods defining your queries.

More Related Contents:

  1. How to map table splitting in EF Code First?
  2. Model First with DbContext, Fails to initialize new DataBase
  3. Getting exact error type in from DbValidationException
  4. Introducing FOREIGN KEY constraint may cause cycles or multiple cascade paths – why?
  5. LINQ to Entities does not recognize the method
  6. Fake DbContext of Entity Framework 4.1 to Test
  7. Entity Framework: table without primary key
  8. Ignoring a class property in Entity Framework 4.1 Code First
  9. Why is .Contains slow? Most efficient way to get multiple entities by primary key?
  10. how to use views in code first entity framework [closed]
  11. Undo changes in entity framework entities
  12. ASP.NET MVC: Is Controller created for every request?
  13. EF LINQ include multiple and nested entities
  14. Does Entity Framework support parallel async queries? [duplicate]
  15. Cannot attach the file *.mdf as database
  16. Generate POCO classes in different project to the project with Entity Framework model
  17. Batching DB commands in Entity Framework 4.0
  18. How to work with Enums in Entity Framework?
  19. instance of entity type cannot be tracked because another instance with same key value is tracked [closed]
  20. Can’t find ADO.net Entity Data Model template in VS2017
  21. Changing the type of an (Entity Framework) entity that is part of an inheritance hierarchy
  22. Entity Framework is Too Slow. What are my options? [closed]
  23. Where to run a duplicate check for an entity
  24. Entity Framework 4 Single() vs First() vs FirstOrDefault()
  25. How can I configure Entity Framework to automatically trim values retrieved for specific columns mapped to char(N) fields?
  26. Do you think it’s advantageous to switch to Entity Framework? [closed]
  27. Foreign keys in entity framework 4.1
  28. Validate data using DataAnnotations with WPF & Entity Framework?
  29. Using Entity Framework entities as business objects?
  30. Entity framework 4.3 run migrations at application start

Leave a Comment