PDO try-catch usage in functions

by

Your implementation is just fine, and it’ll work perfectly well for most purposes.

It’s not necessary to put every query inside a try/catch block, and in fact in most cases you actually don’t want to. The reason for this is that if a query generates an exception, it’s the result of a fatal problem like a syntax error or a database issue, and those are not issues that you should be accounting for with every query that you do.

For example:

try {
    $rs = $db->prepare('SELECT * FROM foo');
    $rs->execute();
    $foo = $rs->fetchAll();
} catch (Exception $e) {
    die("Oh noes! There's an error in the query!");
}

The query here will either work properly or not work at all. The circumstances where it wouldn’t work at all should not ever occur with any regularity on a production system, so they’re not conditions that you should check for here. Doing so is actually counterproductive, because your users get an error that will never change, and you don’t get an exception message that would alert you to the problem.

Instead, just write this:

$rs = $db->prepare('SELECT * FROM foo');
$rs->execute();
$foo = $rs->fetchAll();

In general, the only time that you’ll want to catch and handle a query exception is when you want to do something else if the query fails. For example:

// We're handling a file upload here.
try {
    $rs = $db->prepare('INSERT INTO files (fileID, filename) VALUES (?, ?)');
    $rs->execute(array(1234, '/var/tmp/file1234.txt'));
} catch (Exception $e) {
    unlink('/var/tmp/file1234.txt');
    throw $e;
}

You’ll want to write a simple exception handler that logs or notifies you of database errors that occur in your production environment and displays a friendly error message to your users instead of the exception trace. See http://www.php.net/set-exception-handler for information on how to do that.

More Related Contents:

  1. Can I mix MySQL APIs in PHP?
  2. Can PHP PDO Statements accept the table or column name as parameter?
  3. Can I bind an array to an IN() condition in a PDO query?
  4. How to apply bindValue method in LIMIT clause?
  5. PDOException “could not find driver”
  6. Row count with PDO
  7. PDO get the last ID inserted
  8. How to view query error in PDO PHP
  9. PDO::__construct(): Server sent charset (255) unknown to the client. Please, report to the developers
  10. Insert/update helper function using PDO
  11. PHP PDO – Bind table name? [duplicate]
  12. Is the leading colon for parameter names passed to PDOStatement::bindParam() optional?
  13. How to debug PDO database queries?
  14. Resetting array pointer in PDO results
  15. PDO multiple queries
  16. Parametrized PDO query and `LIMIT` clause – not working [duplicate]
  17. Using htmlspecialchars function with PDO prepare and execute
  18. PDO::PARAM for type decimal?
  19. Update query with PDO and MySQL
  20. Undefined class constant ‘MYSQL_ATTR_INIT_COMMAND’ with pdo
  21. Alternative for mysql_num_rows using PDO
  22. ERROR: SQLSTATE[HY000] [2002] No connection could be made because the target machine actively refused it
  23. Call to undefined method PDO::execute()
  24. How do detect that transaction has already been started?
  25. return one value from database with mysql php pdo
  26. return multiple response data in one response
  27. PDO lastInsertId() always return 0
  28. Do PHP PDO prepared statements need to be escaped?
  29. How can I pass an array of PDO parameters yet still specify their types?
  30. PDO and MySQL ‘between’

Leave a Comment