Problem with std::map::iterator after calling erase()

by

Erasing an element of a map invalidates iterators pointing to that element (after all that element has been deleted). You shouldn’t reuse that iterator.

Since C++11 erase() returns a new iterator pointing to the next element, which can be used to continue iterating:

it = mymap.begin();
while (it != mymap.end()) {
   if (something)
      it = mymap.erase(it);
   else
      it++;
}

Before C++11 you would have to manually advance the iterator to the next element before the deletion takes place, for example like this:

mymap.erase(it++);

This works because the post-increment side-effect of it++ happens before erase() deletes the element. Since this is maybe not immediately obvious, the C++11 variant above should be preferred.

More Related Contents:

  1. Iterator invalidation rules for C++ containers
  2. How to implement an STL-style iterator and avoid common pitfalls?
  3. Why are Standard iterator ranges [begin, end) instead of [begin, end]?
  4. Flattening iterator
  5. comparing iterators from different containers
  6. Why use non-member begin and end functions in C++11?
  7. How are iterators and pointers related?
  8. What is an iterator’s default value?
  9. How to navigate through a vector using iterators? (C++)
  10. Can std::begin work with array parameters and if so, how?
  11. std::vector iterator invalidation
  12. Iterate through a C++ Vector using a ‘for’ loop
  13. Checking if an iterator is valid
  14. Does resizing a vector invalidate iterators?
  15. Why does a push_back on an std::list change a reverse iterator initialized with rbegin?
  16. How to select a random element in std::set?
  17. Are non dereferenced iterators past the “one past-the-end” iterator of an array undefined behavior?
  18. Can raw pointers be used instead of iterators with STL algorithms for containers with linear storage?
  19. How to remove constness of const_iterator?
  20. Checking value exist in a std::map – C++
  21. Creating my own Iterators
  22. Need iterator when using ranged-based for loops
  23. What is iterator invalidation?
  24. What is the reason behind cbegin/cend?
  25. Do STL iterators guarantee validity after collection was changed?
  26. Chaining iterators for C++
  27. Incrementing iterators: Is ++it more efficient than it++? [duplicate]
  28. what is the difference between const_iterator and iterator? [duplicate]
  29. C++ range/xrange equivalent in STL or boost?
  30. Need iterator when using range-based for loops

Leave a Comment