Problem with struct and property in c#

by

Yup, it’s absolutely right. You see, when you fetch My_va, you’re fetching a value – a copy of the current value of my_va. Changing that value would have no benefit, because you’d be immediately discarding the copy. The compiler is stopping you from writing code which doesn’t do what it looks like it does.

In general, avoid mutable structs. They’re evil. In this case, you could (for example) change mystruct to be immutable, but with a method like this:

public mystruct WithStruct1(double newValue)
{
    return new mystruct(newValue, struct2);
}

then change your constructor code to:

My_va = My_va.WithStruct1(10);

… although in this case it’s far more likely (given that you’re in a constructor) that you should be writing:

My_va = new mystruct(10, 0);

Not only should structs be immutable, they should be pretty rare in most codebases, IMO. Other than for Noda Time, I’ve hardly ever written my own custom values types.

Finally, please learn the .NET naming conventions and try to follow them, even for sample code 🙂

More Related Contents:

  1. Why are mutable structs “evil”?
  2. When should I use a struct rather than a class in C#?
  3. How to convert a structure to a byte array in C#?
  4. Why can’t I define a default constructor for a struct in .NET?
  5. Error: “Cannot modify the return value” c#
  6. Structs versus classes
  7. Changing the value of an element in a list of structs
  8. Non-unique enum values
  9. Generic constraints, where T : struct and where T : class
  10. How does native implementation of ValueType.GetHashCode work?
  11. Immutability of structs [duplicate]
  12. Structs, Interfaces and Boxing [duplicate]
  13. Modify Struct variable in a Dictionary
  14. What does the keyword “new” do to a struct in C#?
  15. Struct constructor: “fields must be fully assigned before control is returned to the caller.”
  16. Are Structs always stack allocated or sometimes heap allocated?
  17. Read binary file into a struct
  18. Can structs contain fields of reference types
  19. Why is 16 byte the recommended size for struct in C#?
  20. Is it safe for structs to implement interfaces?
  21. Initializing an Array of Structs in C#
  22. Which is best for data store Struct/Classes?
  23. Non-read only alternative to anonymous types
  24. Why does struct alignment depend on whether a field type is primitive or user-defined?
  25. C# Structs: Unassigned local variable?
  26. Does using public readonly fields for immutable structs work?
  27. Why are public fields faster than properties?
  28. Cycle in the struct layout that doesn’t exist
  29. C# – Value Type Equals method – why does the compiler use reflection?
  30. Are C# structs thread safe?

Leave a Comment