Modify Struct variable in a Dictionary

by

The indexer will return a copy of the value. Making a change to that copy won’t do anything to the value within the dictionary… the compiler is stopping you from writing buggy code. If you want to do modify the value in the dictionary, you’ll need to use something like:

// Note: copying the contents to start with as you can't modify a collection
// while iterating over it
foreach (KeyValuePair<string, MapTile> pair in tilesData.ToList())
{
    MapTile tile = pair.Value;
    tile.bgFrame = tile.bgFrame >= tile.bgAnimation ? 0 : tile.bgFrame + 1;
    tilesData[pair.Key] = tile;
}

Note that this is also avoiding doing multiple lookups for no good reason, which your original code was doing.

Personally I’d strongly advise against having a mutable struct to start with, mind you…

Of course, another alternative is to make it a reference type, at which point you could use:

// If MapTile is a reference type...
// No need to copy anything this time; we're not changing the value in the
// dictionary, which is just a reference. Also, we don't care about the
// key this time.
foreach (MapTile tile in tilesData.Values)
{
    tile.bgFrame = tile.bgFrame >= tile.bgAnimation ? 0 : tile.bgFrame + 1;
}

More Related Contents:

  1. From Dictionary to List
  2. Is there any alternate way of avoiding the Foreach loop? [closed]
  3. Why are mutable structs “evil”?
  4. When should I use a struct rather than a class in C#?
  5. Captured Closure (Loop Variable) in C# 5.0
  6. How does native implementation of ValueType.GetHashCode work?
  7. How can I deserialize JSON with C#?
  8. Iterate Multi-Dimensional Array with Nested Foreach Statement
  9. C# JSON Serialization of Dictionary into {key:value, …} instead of {key:key, value:value, …}
  10. How does foreach work when looping through function results?
  11. Newtonsoft Json Deserialize Dictionary as Key/Value list from DataContractJsonSerializer
  12. How do I segment the elements iterated over in a foreach loop
  13. Does C# have a way of giving me an immutable Dictionary?
  14. Convert list to dictionary using linq and not worrying about duplicates
  15. How to bind Dictionary to ListBox in WinForms
  16. Throw a NullReferenceException while calling the set_item method of a Dictionary object in a multi-threading scenario
  17. Non-read only alternative to anonymous types
  18. Lambda Expression using Foreach Clause [duplicate]
  19. Marshal C++ struct array into C#
  20. Recreating a Dictionary from an IEnumerable
  21. Possible to iterate backwards through a foreach?
  22. How is the c#/.net 3.5 dictionary implemented?
  23. Why are public fields faster than properties?
  24. C# Convert List to Dictionary
  25. The given key was not present in the dictionary. Which key?
  26. Best way to change dictionary key
  27. C# – Value Type Equals method – why does the compiler use reflection?
  28. Map two lists into a dictionary in C#
  29. Why can’t I do foreach (var Item in DataTable.Rows)?
  30. Problem with struct and property in c#

Leave a Comment