pythoncom crashes on KeyDown when used hooked to certain applications

by

I think the problem is that when pyHook gets called back by Windows, the first thing it does is get the window name for the window with focus.

PSTR win_name = NULL;
...
// grab the window name if possible
win_len = GetWindowTextLength(hwnd);
if(win_len > 0) {
  win_name = (PSTR) malloc(sizeof(char) * win_len + 1);
  GetWindowText(hwnd, win_name, win_len + 1);
}

So I think the problem here is that, even if GetWindowText is not returning wide characters, it can return non-ascii characters from an ANSI codepage. That won’t fail, however, until we do this:

// pass the message on to the Python function
arglist = Py_BuildValue("(iiiiiiiz)", wParam, kbd->vkCode, kbd->scanCode, ascii,
                        kbd->flags, kbd->time, hwnd, win_name);

Here, because of the z in the format string, the data in the win_name variable is being converted to a unicode str with Py_BuildValue assuming it is ASCII. But it’s not: and so it can trigger a UnicodeDecodeError. This then causes the arglist to be NULL and therefore your function to be called with no arguments.

So I’m not completely sure on the best fix here. But I just changed both bits of code to use wide characters and unicode instead of ascii, and rebuilt pyHook, and that seemed to fix it. I think it will only work in Python 3 versions, but for Python 2, I think the old pyHook still works anyway.

LPWSTR win_name = NULL;

...
// grab the window name if possible
win_len = GetWindowTextLengthW(hwnd);
if(win_len > 0) {
  win_name = (LPWSTR) malloc(sizeof(wchar_t) * win_len + 1);
  GetWindowTextW(hwnd, win_name, win_len + 1);
}

and

// pass the message on to the Python function
arglist = Py_BuildValue("(iiiiiiiu)", wParam, kbd->vkCode, kbd->scanCode, ascii,
                        kbd->flags, kbd->time, hwnd, win_name);

The problem occurs only with windows with non-ascii characters in their title: Skype is one.

More Related Contents:

  1. ImportError: No module named pywintypes
  2. Django Admin: Using a custom widget for only one model field
  3. Split text after the second occurrence of character
  4. Django viewset has not attribute ‘get_extra_actions’
  5. Type error Unhashable type:set
  6. Create a pandas DataFrame from generator?
  7. environment variables PYSPARK_PYTHON and PYSPARK_DRIVER_PYTHON
  8. Import libraries in lambda layers
  9. Recursive Typing in Python 3.5+ [duplicate]
  10. ‘NoneType’ object is not subscriptable?
  11. Why is Python’s eval() rejecting this multiline string, and how can I fix it?
  12. In sklearn.decomposition.PCA, why are components_ negative?
  13. How to deal with unicode string in URL in python3?
  14. Search and replace dots and commas in pandas dataframe
  15. Comma separated variable assignment [duplicate]
  16. Python CGI – UTF-8 doesn’t work
  17. A more pythonic way to define an enum with dynamic members
  18. How to make a tkinter canvas background transparent?
  19. Mergesort with Python
  20. Python how to get the calling function (not just its name)?
  21. Skip elements on a condition based in a list comprehension in python
  22. Kivy error, [CRITICAL] [Text ] unable to find any valuable text provider (python 3.6.1) (windows 10)
  23. Anaconda export Environment file
  24. Execute Python script within Jupyter notebook using a specific virtualenv
  25. Correct Use Of Global Variables In Python 3
  26. Python TypeError on regex [duplicate]
  27. Why do I get a KeyError when using pandas apply?
  28. TypedDict when keys have invalid names
  29. Pandas(Python) : Fill empty cells with with previous row value?
  30. Is this the best way to add an extra dimension to a numpy array in one line of code?

Leave a Comment