Raise event thread safely – best practice [duplicate]

by

There is a tiny chance that SomethingHappened becomes null after the null check but before the invocation. However, MulticastDelagates are immutable, so if you first assign a variable, null check against the variable and invoke through it, you are safe from that scenario (self plug: I wrote a blog post about this a while ago).

There is a back side of the coin though; if you use the temp variable approach, your code is protected against NullReferenceExceptions, but it could be that the event will invoke event listeners after they have been detached from the event. That is just something to deal with in the most graceful way possible.

In order to get around this I have an extension method that I sometimes use:

public static class EventHandlerExtensions
{
    public static void SafeInvoke<T>(this EventHandler<T> evt, object sender, T e) where T : EventArgs
    {
        if (evt != null)
        {
            evt(sender, e);
        }
    }
}

Using that method, you can invoke the events like this:

protected void OnSomeEvent(EventArgs e)
{
    SomeEvent.SafeInvoke(this, e);
}

More Related Contents:

  1. Understanding events and event handlers in C#
  2. Do event handlers stop garbage collection from occurring?
  3. Global mouse event handler
  4. How can I create a dynamic button click event on a dynamic button?
  5. C#: Difference between ‘ += anEvent’ and ‘ += new EventHandler(anEvent)’
  6. How do I make an Event in the Usercontrol and have it handled in the Main Form?
  7. Is it bad to not unregister event handlers?
  8. How to handle key press event in console application
  9. Order of event handler execution
  10. How can I subscribe multiple buttons to the same event handler and act according to what button was clicked?
  11. How to trigger event when a variable’s value is changed?
  12. Pass parameter to EventHandler [duplicate]
  13. C# How to find if an event is hooked up
  14. How do I raise an event via reflection in .NET/C#?
  15. C# pattern to prevent an event handler hooked twice [duplicate]
  16. -event- can only appear on the left hand side of += or -=
  17. How to handle add to list event?
  18. Garbage collection when using anonymous delegates for event handling
  19. How to pass an event to a method?
  20. Difference between the KeyDown Event, KeyPress Event and KeyUp Event in Visual Studio
  21. How would it be possible to remove all event handlers of the ‘Click’ event of a ‘Button’?
  22. Registry Watcher C#
  23. asp.net dynamically button with event handler
  24. How to unsubscribe from an event which uses a lambda expression?
  25. Should I always disconnect event handlers in the Dispose method?
  26. How to get a right click mouse event? Changing EventArgs to MouseEventArgs causes an error in Form1Designer?
  27. What’s wrong with calling Invoke, regardless of InvokeRequired?
  28. Handling end process of a windows app
  29. Detect when a form has been closed c#
  30. Handling scroll event on listview in c#

Leave a Comment