Refactor this code snippet [closed]

by

The common part with list and map working can be moved out from if/else:

Map<String, MyObject> hashMap = new HashMap<>();

List<Value> listOfvalues;
if (!hashMap.containsKey(key)) {
    listOfvalues = new ArrayList<>();
} else {
    listOfvalues = hashMap.get(key).getvalues();
    log.info(String.format("Duplicate key: %s. Previous Value(s): %s", key,  listOfvalues));
}

listOfvalues.add(Value.builder().withValue1(Value1).withValue2(Value2).build());
hashMap.put(key, MyObject.builder().withkey(key).withvalues(listOfvalues).build());

More Related Contents:

  1. How to find unused/dead code in java projects [closed]
  2. How to avoid a lot of if else conditions
  3. How to simplify a null-safe compareTo() implementation?
  4. Refactoring if/else logic
  5. How to use IntelliJ IDEA to find all unused code?
  6. Find unused classes in a Java Eclipse project
  7. Is there any Eclipse refactoring API that I can call programmatically?
  8. Writing a new refactoring plugin for Eclipse?
  9. How to instantiate Spring managed beans at runtime?
  10. How to convert to Java 8 map grouping by Map [closed]
  11. How to map a composite key with JPA and Hibernate?
  12. How to switch between frames in Selenium WebDriver using Java
  13. Get size of folder or file
  14. Adding n hours to a date in Java?
  15. Convert Json Array to normal Java list
  16. How to change font size in Eclipse for Java text editors?
  17. How much data can a List can hold at the maximum?
  18. Print all the Spring beans that are loaded
  19. Is there any way to do n-level nested loops in Java?
  20. Garbage collection behaviour for String.intern()
  21. How to check if a subclass is an instance of a class at runtime? [duplicate]
  22. Do lambda expressions have any use other than saving lines of code?
  23. How to delete old logs with log4j2
  24. Inherited abstract class with JPA (+Hibernate)
  25. How do you find a roman numeral equivalent of an integer
  26. How can I determine whether a Java class is abstract by reflection
  27. Run two Java programs from Eclipse at once?
  28. Is the Main method must needed in a Java program?
  29. How many Java objects are generated by this – new String(“abcd”)
  30. Parse JSON object with string and value only

Leave a Comment