Refactoring if/else logic

by

You should use Strategies, possibly implemented within an enum, e.g.:

enum UserType {
  ADMIN() {
    public void doStuff() {
      // do stuff the Admin way
    }
  },
  STUDENT {
    public void doStuff() {
      // do stuff the Student way
    }
  };

  public abstract void doStuff();
}

As the code structure within each outermost if branch in your code looks pretty much the same, in the next step of refactoring you might want to factor out that duplication using template methods. Alternatively, you might turn Location (and possibly Age) into a strategy as well.

Update: in Java4, you can implement a typesafe enum by hand, and use plain old subclassing to implement the different strategies.

More Related Contents:

  1. How to avoid a lot of if else conditions
  2. Why can't we declare variables in if statement?
  3. java if else errors not working properly
  4. Repeat the “if” statement if it has to go to the “else” statement
  5. Refactor this code snippet [closed]
  6. How to count the results in a for loop?
  7. Code after if block inside a for loop doesn’t work
  8. Will my program execute “else” even if it executed my “if”?
  9. Why am I getting “Error: ‘else’ without ‘if'”? [duplicate]
  10. Performance of java if-else with return statement [duplicate]
  11. New to Java and having issues writing and example
  12. ArrayList, Loop and requisite if can not work that i want – Java 11
  13. What is the relative performance difference of if/else versus switch statement in Java?
  14. How can I check if an app running on Android?
  15. Using switch statement with a range of value in each case?
  16. Is there a difference in removing the curly braces from If statements in java
  17. Java String – See if a string contains only numbers and not letters
  18. What is better: multiple “if” statements or one “if” with multiple conditions?
  19. How to check if a string starts with one of several prefixes?
  20. Which is more effective: if (null == variable) or if (variable == null)? [duplicate]
  21. How to use this boolean in an if statement?
  22. Java: If vs. Switch
  23. variable access outside of if statement
  24. How to simplify a null-safe compareTo() implementation?
  25. How can a Java variable be different from itself?
  26. Short IF – ELSE statement
  27. Why Java does not see that Integers are equal?
  28. Is there any Eclipse refactoring API that I can call programmatically?
  29. If-else working, switch not [duplicate]
  30. How is if/while condition evaluated when we use assignments instead of comparison?

Leave a Comment