Reverse String C++ using char array

by

sizeof(str) does not do what you expect.

Given a char *str, sizeof(str) will not give you the length of that string. Instead, it will give you the number of bytes that a pointer occupies. You are probably looking for strlen() instead.

If we fixed that, we would have:

for(i=0;i<strlen(str)/2;i++)
{
    char temp=str[i];
    str[i]=str[strlen(str)-i-1];
    str[strlen(str)-i-1]=temp;
}

This is C++, use std::swap()

In C++, if you want to swap the contents of two variables, use std::swap instead of the temporary variable.

So instead of:

char temp=str[i];
str[i]=str[strlen(str)-i-1];
str[strlen(str)-i-1]=temp;

You would just write:

swap(str[i], str[sizeof(str) - i - 1]);

Note how much clearer that is.

You’re using C++, just use std::reverse()

std::reverse(str, str + strlen(str));

Global variables

It’s extremely poor practice to make variables global if they don’t need to be. In particular, I’m referring to i about this.

Executive Summary

If I was to write this function, it would look like one of the two following implementations:

void reverseChar(char* str) {
    const size_t len = strlen(str);

    for(size_t i=0; i<len/2; i++)
        swap(str[i], str[len-i-1]);
}

void reverseChar(char* str) {
    std::reverse(str, str + strlen(str));
}

When tested, both of these produce dlrow olleh on an input of hello world.

More Related Contents:

  1. how to change to c code while using for loop and array
  2. Getting a segmentation error when printing my array of strings
  3. The array index doesnt show the character [closed]
  4. splitting a string into an array in C++ without using vector
  5. How to convert a char array to a string?
  6. What am I not understanding about getline+strings?
  7. Braces around string literal in char array declaration valid? (e.g. char s[] = {“Hello World”})
  8. Copying non null-terminated unsigned char array to std::string
  9. Parse string containing numbers into integer array
  10. How can a char pointer be initialized with a string (Array of characters) but an int pointer not with an array of integer? [duplicate]
  11. Where are string literals stored, and can I modify them?
  12. What is the difference between '.' and '->' when used in array? [closed]
  13. Determine if int is not 0 with no if statements
  14. C++ Convert string (or char*) to wstring (or wchar_t*)
  15. What are the mechanics of short string optimization in libc++?
  16. Remove spaces from std::string in C++
  17. Check if a string contains a string in C++
  18. View array in Visual Studio debugger? [duplicate]
  19. C++ string::find complexity
  20. Is it reasonable to use std::basic_string as a contiguous buffer when targeting C++03?
  21. C++ correct way to return pointer to array from function
  22. Store an int in a char array?
  23. what is the best modern c++ approach to construct and manipulate a 2d array [closed]
  24. How to reliably get size of C-style array?
  25. Are non dereferenced iterators past the “one past-the-end” iterator of an array undefined behavior?
  26. Press Enter to Continue
  27. Multidimensional variable size array in C++
  28. Why do we even need the “delete[]” operator?
  29. how to get hash code of a string in c++
  30. How to find and replace all occurrences of a substring in a string?

Leave a Comment