Short IF – ELSE statement

by

The “ternary expression” x ? y : z can only be used for conditional assignment. That is, you could do something like:

String mood = inProfit() ? "happy" : "sad";

because the ternary expression is returning something (of type String in this example).

It’s not really meant to be used as a short, in-line if-else. In particular, you can’t use it if the individual parts don’t return a value, or return values of incompatible types. (So while you could do this if both method happened to return the same value, you shouldn’t invoke it for the side-effect purposes only).

So the proper way to do this would just be with an if-else block:

if (jXPanel6.isVisible()) {
    jXPanel6.setVisible(true);
}
else {
    jXPanel6.setVisible(false);
}

which of course can be shortened to

jXPanel6.setVisible(jXPanel6.isVisible());

Both of those latter expressions are, for me, more readable in that they more clearly communicate what it is you’re trying to do. (And by the way, did you get your conditions the wrong way round? It looks like this is a no-op anyway, rather than a toggle).

Don’t mix up low character count with readability. The key point is what is most easily understood; and mildly misusing language features is a definite way to confuse readers, or at least make them do a mental double-take.

More Related Contents:

  1. Why can't we declare variables in if statement?
  2. If-else One line statement (with string and integer) [closed]
  3. java if else errors not working properly
  4. how to make an if statement then send a message [closed]
  5. Result from printing statement and if statement differ
  6. Conditional Statement on Java7
  7. Android: If statement being skipped even if condition is correct
  8. I keep getting java.lang.ArrayIndexOutOfBoundsException: 5! How do I fix this? [closed]
  9. Why am I getting “Error: ‘else’ without ‘if'”? [duplicate]
  10. Multiple statement is passed in IF condition using OR, how to find which statement is true?
  11. New to Java and having issues writing and example
  12. Why is my if statement an error?
  13. Semicolon at end of ‘if’ statement
  14. Error: ‘else’ without ‘if’
  15. && (AND) and || (OR) in IF statements
  16. Best way to format multiple ‘or’ conditions in an if statement
  17. Compiler error when declaring a variable inside if condition and no curly braces
  18. Java Swing; Two classes, where to put if statements and new actionlisteners?
  19. How to avoid a lot of if else conditions
  20. Why doesn’t my compare work between char and int in Java?
  21. How to use this boolean in an if statement?
  22. Using variables outside of an if-statement
  23. Java if vs. try/catch overhead
  24. Refactoring if/else logic
  25. How to remove large if-else-if chain [duplicate]
  26. How is String in switch statement more efficient than corresponding if-else statement?
  27. Which “if” construct is faster – statement or ternary operator?
  28. Nested if-else behaviour without braces
  29. “Wrong” return type when using if vs. ternary opertator in Java
  30. How is if/while condition evaluated when we use assignments instead of comparison?

Leave a Comment