Should an async API ever throw synchronously?

by

Ultimately the decision to synchronously throw or not is up to you, and you will likely find people who argue either side. The important thing is to document the behavior and maintain consistency in the behavior.

My opinion on the matter is that your second option – passing the error into the callback – seems more elegant. Otherwise you end up with code that looks like this:

try {
    getUserById(7, function (response) {
       if (response.isSuccess) {
           //Success case
       } else {
           //Failure case
       }
    });
} catch (error) {
    //Other failure case
}

The control flow here is slightly confusing.

It seems like it would be better to have a single if / else if / else structure in the callback and forgo the surrounding try / catch.

More Related Contents:

  1. How to return many Promises and wait for them all before doing other stuff
  2. Why does .json() return a promise?
  3. async/await always returns promise
  4. How to turn this callback into a promise using async/await?
  5. Asynchronous exception handling with bluebird promises
  6. What is the difference between JavaScript promises and async await?
  7. How to wait for a JavaScript Promise to resolve before resuming function?
  8. Node JS Promise.all and forEach
  9. $.Deferred: How to detect when every promise has been executed
  10. How to async await in react render function?
  11. What does $.when.apply($, someArray) do?
  12. Why does the Promise constructor need an executor?
  13. Why can I not throw inside a Promise.catch handler?
  14. How to block for a javascript promise and return the resolved result? [duplicate]
  15. using async await and .then together
  16. How to implement a pseudo blocking async queue in JS/TS?
  17. Are JavaScript Promise asynchronous?
  18. How to return from a Promise’s catch/then block?
  19. Javascript – if with asynchronous case
  20. Using mongoose promises with async/await
  21. What are asynchronous functions in JavaScript? What is “async” and “await” in JavaScript?
  22. map() function with async/await
  23. How to use Promise.all with an object as input
  24. Javascript Asynchronous Exception Handling with node.js
  25. Why are javascript promises asynchronous when calling only synchronous functions?
  26. Produce a promise which depends on recursive promises
  27. When does async function actually return a pending promise?
  28. Properly batch nested promises in Node
  29. JavaScript asynchronous programming: promises vs generators
  30. Promise.all is returning an array of undefined and resolves before being done

Leave a Comment