Should I call Close() or Dispose() for stream objects?

by

A quick jump into Reflector.NET shows that the Close() method on StreamWriter is:

public override void Close()
{
    this.Dispose(true);
    GC.SuppressFinalize(this);
}

And StreamReader is:

public override void Close()
{
    this.Dispose(true);
}

The Dispose(bool disposing) override in StreamReader is:

protected override void Dispose(bool disposing)
{
    try
    {
        if ((this.Closable && disposing) && (this.stream != null))
        {
            this.stream.Close();
        }
    }
    finally
    {
        if (this.Closable && (this.stream != null))
        {
            this.stream = null;
            /* deleted for brevity */
            base.Dispose(disposing);
        }
    }
}

The StreamWriter method is similar.

So, reading the code it is clear that that you can call Close() & Dispose() on streams as often as you like and in any order. It won’t change the behaviour in any way.

So it comes down to whether or not it is more readable to use Dispose(), Close() and/or using ( ... ) { ... }.

My personal preference is that using ( ... ) { ... } should always be used when possible as it helps you to “not run with scissors”.

But, while this helps correctness, it does reduce readability. In C# we already have plethora of closing curly braces so how do we know which one actually performs the close on the stream?

So I think it is best to do this:

using (var stream = ...)
{
    /* code */

    stream.Close();
}

It doesn’t affect the behaviour of the code, but it does aid readability.

More Related Contents:

  1. Reading large text files with streams in C#
  2. Does disposing streamreader close the stream?
  3. simultaneous read-write a file in C#
  4. An elegant way to consume (all bytes of a) BinaryReader?
  5. Adding a Line to the Middle of a File with .NET
  6. When or if to Dispose HttpResponseMessage when calling ReadAsStreamAsync?
  7. C# How to replace spaces with new lines [closed]
  8. How do I copy the contents of one stream to another?
  9. Memory Leak using StreamReader and XmlSerializer
  10. Is there any way to close a StreamWriter without closing its BaseStream?
  11. How to read a large (1 GB) txt file in .NET?
  12. How do I convert struct System.Byte byte[] to a System.IO.Stream object in C#?
  13. Deserialize json array stream one item at a time
  14. “Parameter not valid” exception loading System.Drawing.Image
  15. How to find and replace text in a file
  16. Async network operations never finish
  17. What happens if i return before the end of using statement? Will the dispose be called?
  18. HttpWebRequest & Native GZip Compression
  19. Writing file to web server – ASP.NET
  20. ReadAllLines for a Stream object?
  21. Compute a hash from a stream of unknown length in C#
  22. Who should call Dispose on IDisposable objects when passed into another object?
  23. What is the difference between using and await using? And how can I decide which one to use?
  24. Guidelines For Dispose() and Ninject
  25. HTTPWebResponse + StreamReader Very Slow
  26. How to get a MemoryStream from a Stream in .NET?
  27. Do I need to Dispose a SemaphoreSlim?
  28. Who Disposes of an IDisposable public property?
  29. Determining if IDisposable should extend an interface or be implemented on a class implementing said interface
  30. File.ReadLines without locking it?

Leave a Comment