simple calculation not working for some reason

by

i checked the values while debugging and with FilesCompleted being 295 and TotalFilesCount being 25002 the returnvalue var is just 0, it should be 1 already.

No, because all the arithmetic is being done with integers. So first this expression is evaluated:

(FilesCompleted / TotalFilesCount)

That’s 295 / 25002. The result of that integer arithmetic is 0… and when you then multiply it by 100, you’ve still got 0. The simplest fix is just to do the multiplication first:

int returnvalue = (FilesCompleted * 100) / TotalFilesCount;

Note that that will overflow if FilesCompleted is greater than int.MaxValue / 100. You could fix that by either doing everything in floating point arithmetic:

int returnvalue = (int)((FilesCompleted * 100.0) / TotalFilesCount);

… or by using long integer arithmetic:

int returnvalue = (int)((FilesCompleted * 100L) / TotalFilesCount);

Neither of these are necessary if you don’t expect to have an insane number of files, of course. (You’re fine up to 42 million files…)

As a side note, your parameter names violate .NET naming conventions. They should be camelCased – totalFilesCount and filesCompleted.

More Related Contents:

  1. Difference between ObservableCollection and BindingList
  2. XML serialization of interface property
  3. String Concatenation using ‘+’ operator
  4. Kill process tree programmatically in C#
  5. Is there a good way to convert between BitmapSource and Bitmap?
  6. How to save a List on Settings.Default?
  7. How do I determine a mapped drive’s actual path?
  8. Get File Icon used by Shell
  9. Escape invalid XML characters in C#
  10. What is the fastest way to create a checksum for large files in C#
  11. Why is LINQ .Where(predicate).First() faster than .First(predicate)?
  12. DataGrid column width doesn’t auto-update
  13. Travel through pixels in BMP
  14. JSON Serializer object with internal properties
  15. memcpy function in c# [duplicate]
  16. Finding out if a type implements a generic interface
  17. convert datetime to date format dd/mm/yyyy
  18. .NET Core vs Mono
  19. Can I Override with derived types?
  20. Application_Error in global.asax not catching errors in WebAPI
  21. Validating file types by regular expression
  22. ASP.NET Web API and [Serializable] class
  23. trying to convert rgb from a .net Color to a string such as “red” or “blue”
  24. NHibernate.MappingException: No persister for: XYZ
  25. Is the List.ForEach() method gone?
  26. Can you make an alpha transparent PNG with C#?
  27. Should we use “workstation” garbage collection or “server” garbage collection?
  28. Using .net standard 1.5 lib in .net 4.6.2 misses System.Runtime 4.1.0.0
  29. Map two lists into a dictionary in C#
  30. Why remove unused using directives in C#?

Leave a Comment