spring creates proxy for wrong classes when using aop class level annotation

by

Andy Brown is right, it is by design. The reason is that according to the AspectJ manual pointcut designators such as @args, @this, @target, @within, @withincode, and @annotation (or the subset of those available in Spring AOP) are used to match based on the presence of an annotation at runtime. This is why in the Spring debug log you see that proxies are created for all components which might need aspect functionality.

If you want to avoid that, you can refactor your aspect into something like this at the cost of an uglier pointcut and even uglier reflection in the advice code:

import org.aspectj.lang.ProceedingJoinPoint;
import org.aspectj.lang.annotation.Around;
import org.aspectj.lang.annotation.Aspect;
import org.aspectj.lang.reflect.MethodSignature;
import org.springframework.stereotype.Component;

import java.lang.annotation.Annotation;

@Component
@Aspect
public class AspectA {
  @Around("execution(* (@MyAnnotation *).*(..)) || execution(@MyAnnotation * *(..))")
  public Object process(ProceedingJoinPoint joinPoint) throws Throwable {
    MyAnnotation myAnnotation = null;
    for (Annotation annotation : ((MethodSignature) joinPoint.getSignature()).getMethod().getDeclaredAnnotations()) {
      if (annotation instanceof MyAnnotation) {
        myAnnotation = (MyAnnotation) annotation;
        break;
      }
    }
    if (myAnnotation == null) {
      myAnnotation = joinPoint.getTarget().getClass().getAnnotationsByType(MyAnnotation.class)[0];
    }
    System.out.println("AspectA: myAnnotation target:" + joinPoint.getTarget().getClass().getSimpleName());
    System.out.println(" condition:" + myAnnotation.condition());
    System.out.println(" key:" + myAnnotation.key());
    System.out.println(" value:" + myAnnotation.value());
    return joinPoint.proceed();
  }
}

If neither the bean’s class nor any of its methods bears the annotation, no proxy will be created. The advice detects both types of annotation, but prefers a method annotation if both are present.

Update: Instead of this workaround you could of course use full AspectJ from within Spring and avoid proxies altogether.

More Related Contents:

  1. Spring autowired bean for @Aspect aspect is null
  2. AspectJ pointcut expression match parameter annotations at any position
  3. Spring @Transaction method call by the method within the same class, does not work?
  4. Spring – @Transactional – What happens in background?
  5. Spring AOP not working for method call inside another method
  6. Spring AOP vs AspectJ
  7. @AspectJ pointcut for all methods of a class with specific annotation
  8. Spring autowiring using @Configurable
  9. Tracking down cause of Spring’s “not eligible for auto-proxying”
  10. Use of proxies in Spring AOP
  11. Spring AOP not working, when the method is called internally within a bean
  12. Spring AOP Advice on Annotated Controllers
  13. How to instrument / advice a Spring Data (JPA) repository?
  14. Aspectj overwrite an argument of a method
  15. Configuring AspectJ aspects using Spring IoC with JavaConfig?
  16. What is the proper way to re-attach detached objects in Hibernate?
  17. Spring: how do I inject an HttpServletRequest into a request-scoped bean?
  18. Spring schemaLocation fails when there is no internet connection
  19. Spring Boot Multiple Datasource
  20. No Dialect mapping for JDBC type: 1111
  21. Hibernate could not fetch the SequenceInformation from the database
  22. Spring MVC – @Valid on list of beans in REST service
  23. How to reload a @Value property from application.properties in Spring? [duplicate]
  24. No String-argument constructor/factory method to deserialize from String value (”)
  25. How do I run a spring boot executable jar in a Production environment?
  26. Anyway to @Inject/@Autowire an inner class into an outer class?
  27. How does Spring 3 expression language interact with property placeholders?
  28. How do you configure Embedded MongDB for integration testing in a Spring Boot application?
  29. How to make a database listener with java?
  30. How to pass a session attribute as method argument (parameter) with Spring MVC

Leave a Comment