Subclassing dict: should dict.__init__() be called?

by

You should probably call dict.__init__(self) when subclassing; in fact, you don’t know what’s happening precisely in dict (since it’s a builtin), and that might vary across versions and implementations. Not calling it may result in improper behaviour, since you can’t know where dict is holding its internal data structures.

By the way, you didn’t tell us what you want to do; if you want a class with dict (mapping) behaviour, and you don’t really need a dict (e.g. there’s no code doing isinstance(x, dict) anywhere in your software, as it should be), you’re probably better off at using UserDict.UserDict or UserDict.DictMixin if you’re on python <= 2.5, or collections.MutableMapping if you’re on python >= 2.6 . Those will provide your class with an excellent dict behaviour.

EDIT: I read in another comment that you’re not overriding any of dict’s method! Then there’s no point in subclassing at all, don’t do it.

def createImageDb(directory):
    d = {}
    # do something to fill in the dict
    return d

EDIT 2: you want to inherit from dict to add new methods, but you don’t need to override any. Than a good choice might be:

class MyContainer(dict):
    def newmethod1(self, args):
        pass

    def newmethod2(self, args2):
        pass


def createImageDb(directory):
    d = MyContainer()
    # fill the container
    return d

By the way: what methods are you adding? Are you sure you’re creating a good abstraction? Maybe you’d better use a class which defines the methods you need and use a “normal” dict internally to it.

Factory func:
http://en.wikipedia.org/wiki/Factory_method_pattern

It’s simply a way of delegating the construction of an instance to a function instead of overriding/changing its constructors.

More Related Contents:

  1. Subclassing Python dictionary to override __setitem__
  2. How do I merge two dictionaries in a single expression (take union of dictionaries)?
  3. Iterating over dictionaries using ‘for’ loops
  4. Delete an element from a dictionary
  5. How to merge multiple dicts with same key or different key?
  6. Rename a dictionary key
  7. Modifying a Python dict while iterating over it
  8. What’s a correct and good way to implement __hash__()?
  9. Safe method to get value of nested dictionary
  10. How to convert an XML string to a dictionary?
  11. How to sum dict elements
  12. How to add multiple values to a dictionary key in python?
  13. Extract subset of key-value pairs from dictionary?
  14. How does the key argument in python’s sorted function work?
  15. Convert a python dict to a string and back
  16. sort dict by value python [duplicate]
  17. Is there anything faster than dict()?
  18. Why can’t I subclass datetime.date?
  19. Merge several Python dictionaries
  20. Python: Elegantly merge dictionaries with sum() of values [duplicate]
  21. Efficient way to remove keys with empty strings from a dict
  22. How to convert a list to a dictionary with indexes as values?
  23. Understanding __init_subclass__
  24. Python: Inherit the superclass __init__
  25. “unpacking” a passed dictionary into the function’s name space in Python?
  26. How to detect if any element in a dictionary changes?
  27. Python Pickling Dictionary EOFError
  28. get python dictionary from string containing key value pairs
  29. Slicing a dictionary
  30. How to create a nested dictionary from a list in Python?

Leave a Comment