idisposable - w3toppers.com

Async network operations never finish

So i’ve made an extension method on IDisposable that creates a CancellationToken that disposes the connection on timeout, so the task finishes and everything carries on: public static IDisposable CreateTimeoutScope(this IDisposable disposable, TimeSpan timeSpan) { var cancellationTokenSource = new CancellationTokenSource(timeSpan); var cancellationTokenRegistration = cancellationTokenSource.Token.Register(disposable.Dispose); return new DisposableScope( () => { cancellationTokenRegistration.Dispose(); cancellationTokenSource.Dispose(); disposable.Dispose(); }); } … Read more

How do I dispose my filestream when implementing a file download in ASP.NET?

You don’t need to dispose the stream. It will be disposed by the FileStreamResult.WriteFile method. Code excerpt from this class: public FileStreamResult(Stream fileStream, string contentType) : base(contentType) { if (fileStream == null) { throw new ArgumentNullException(“fileStream”); } this.FileStream = fileStream; } protected override void WriteFile(HttpResponseBase response) { Stream outputStream = response.OutputStream; using (this.FileStream) { byte[] … Read more

Dispose, when is it called?

A couple of important points should be made to address the OP’s question: .NET GC is non-deterministic (i.e. you never know nor should you depend on when it happens) Dispose is never called by the .NET Framework; you must call it manually – preferably by wrapping its creation in a using() block. Explicitly setting a … Read more

Should you implement IDisposable.Dispose() so that it never throws?

The Framework Design Guidelines (2nd ed) has this as (§9.4.1): AVOID throwing an exception from within Dispose(bool) except under critical situations where the containing process has been corrupted (leaks, inconsistent shared state, etc.). Commentary [Edit]: There are guidelines, not hard rules. And this is an “AVOID” not a “DO NOT” guideline. As noted (in comments) … Read more

How do you reconcile IDisposable and IoC?

You definitely do not want to call Dispose() on an object that was injected into your class. You can’t make the assumption that you are the only consumer. Your best bet is to wrap your unmanaged object in some managed interface: public class ManagedFileReader : IManagedFileReader { public string Read(string path) { using (StreamReader reader … Read more

Using statement vs. IDisposable.Dispose()

using is basically the equivalent of: try { // code } finally { obj.Dispose(); } So it also has the benefit of calling Dispose() even if an unhandled exception is thrown in the code within the block.

Should I call Close() or Dispose() for stream objects?

A quick jump into Reflector.NET shows that the Close() method on StreamWriter is: public override void Close() { this.Dispose(true); GC.SuppressFinalize(this); } And StreamReader is: public override void Close() { this.Dispose(true); } The Dispose(bool disposing) override in StreamReader is: protected override void Dispose(bool disposing) { try { if ((this.Closable && disposing) && (this.stream != null)) { … Read more

Will the Garbage Collector call IDisposable.Dispose for me?

The .Net Garbage Collector calls the Object.Finalize method of an object on garbage collection. By default this does nothing and must be overidden if you want to free additional resources. Dispose is NOT automatically called and must be explicity called if resources are to be released, such as within a ‘using’ or ‘try finally’ block … Read more

Should I Dispose() DataSet and DataTable?

Here are a couple of discussions explaining why Dispose is not necessary for a DataSet. To Dispose or Not to Dispose ?: The Dispose method in DataSet exists ONLY because of side effect of inheritance– in other words, it doesn’t actually do anything useful in the finalization. Should Dispose be called on DataTable and DataSet … Read more

Do HttpClient and HttpClientHandler have to be disposed between requests?

The general consensus is that you do not (should not) need to dispose of HttpClient. Many people who are intimately involved in the way it works have stated this. See Darrel Miller’s blog post and a related SO post: HttpClient crawling results in memory leak for reference. I’d also strongly suggest that you read the … Read more