How do I dispose my filestream when implementing a file download in ASP.NET?

by

You don’t need to dispose the stream. It will be disposed by the FileStreamResult.WriteFile method. Code excerpt from this class:

public FileStreamResult(Stream fileStream, string contentType) : base(contentType)
{
    if (fileStream == null)
    {
        throw new ArgumentNullException("fileStream");
    }
    this.FileStream = fileStream;
}

protected override void WriteFile(HttpResponseBase response)
{
    Stream outputStream = response.OutputStream;
    using (this.FileStream)
    {
        byte[] buffer = new byte[0x1000];
        while (true)
        {
            int count = this.FileStream.Read(buffer, 0, 0x1000);
            if (count == 0)
            {
                return;
            }
            outputStream.Write(buffer, 0, count);
        }
    }
}

Notice the using. When you call File(dg.GetDocumentStream(), "text/plain", filename) from your controller this invokes the constructor which stores the stream into a public property which is disposed during the rendering.

Conclusion: you don’t need to worry about disposing the stream obtain with dg.GetDocumentStream().

More Related Contents:

  1. Loop through enum result property
  2. How do you create a dropdownlist from an enum in ASP.NET MVC?
  3. How to return a file (FileContentResult) in ASP.NET WebAPI
  4. ASP.NET MVC 5 group of radio buttons
  5. Questions about using Ninject
  6. Passing data between different controller action methods
  7. Is Task.Run considered bad practice in an ASP .NET MVC Web Application?
  8. Remote Validation for LIST of MODELs
  9. Passing data to Master Page in ASP.NET MVC
  10. Is it secure to store passwords in cookies?
  11. C# mvc 3 using selectlist with selected value in view
  12. Visual Studio – Resx File default ‘internal’ to ‘public’
  13. ASP.NET MVC – How to show unauthorized error on login page?
  14. Project builds but can’t publish
  15. How to make Check Box List in ASP.Net MVC
  16. Questions about Entity Framework Context Lifetime
  17. How do I setup multiple auth schemes in ASP.NET Core 2.0?
  18. I’m getting the “missing a using directive or assembly reference” and no clue what’s going wrong
  19. MvcSiteMap generating a Menu without messing the breadcumbs
  20. how to get mac address of client that browse web site by asp.net mvc c#
  21. The model item passed into the dictionary is of type ‘mvc.Models.ModelA’ but this dictionary requires a model item of type ‘mvc.Models.ModelB‘
  22. Get UserID of logged-in user in Asp.Net MVC 5
  23. Can I use ASP.NET MVC together with regular ASP.NET Web forms
  24. ASP.NET 5 MVC: unable to connect to web server ‘IIS Express’
  25. {version} wildcard in MVC4 Bundle
  26. ASP.NET – AppDomain.CurrentDomain.GetAssemblies() – Assemblies missing after AppDomain restart
  27. WebAPI Request Streaming support
  28. Opposite of [compare(” “)] data annotation in .net?
  29. Asp.Net Routing: How do I ignore multiple wildcard routes?
  30. An error occurred attempting to determine the process id of dotnet.exe which is hosting your application. One or more error occured

Leave a Comment