Valid use of accessors in init and dealloc methods?

by

EDIT (Feb 13, 2013): As noted in my comment below, and especially since the addition of ARC, I’ve changed my mind on this. Prior to ARC, I saw a lot of crash-causing bugs due to incorrect ivar assignments in init. IMO, especially working with junior teams, the rare problems with using accessors in init were outweighed by the common bugs of ivar access. Since ARC has eliminated these kinds of bugs, the rare-but-possible bugs that using accessor in init can cause are more important, and so I’ve switched to supporting the direct use of ivars in init and dealloc, and only in those places; accessors everywhere else that is possible (obviously you can’t use accessors inside of the accessor itself….)

PRE-ARC answer

I strongly disagree with those who object to accessors in -init. In almost all cases this is a very good place to use accessors, and it saves a lot of bugs I’ve seen in new Cocoa coders who invariably fail to retain when assigning in -init.

-dealloc is a tougher call. I have a natural inclination to use accessors there (so that they are used everywhere), but it can cause headaches due to KVO (or even NSNotifications if you post a change notification in your setter). That said, while I don’t use accessors in -dealloc, I consider it very debatable and Apple is very inconsistent about it (we know they’re calling setView: in UIViewController’s -dealloc for instance).

In any case, I would say that under-use of accessors has caused 100x the bugs of over-use. I would always err towards using them except when there is a strong reason not to.

More Related Contents:

  1. Initializing a property, dot notation
  2. Get an object properties list in Objective-C
  3. Synthesized property and variable with underscore prefix: what does this mean? [duplicate]
  4. Must every ivar be a property?
  5. @synthesize vs @dynamic, what are the differences?
  6. Compiler error: “initializer element is not a compile-time constant”
  7. Are ints always initialized to 0?
  8. In Objective-C on iOS, what is the (style) difference between “self.foo” and “foo” when using synthesized getters?
  9. How can I add properties to an object at runtime?
  10. Should I refer to self.property in the init method with ARC?
  11. When to access properties with ‘self’
  12. What is the difference between ivars and properties in Objective-C
  13. Is there any reason to declare ivars if you’re using properties exclusively in Objective-C?
  14. Properties and accessors in Objective-C
  15. @property definitions with ARC: strong or retain?
  16. Swift readonly external, readwrite internal property
  17. What is the visibility of @synthesized instance variables?
  18. How is release handled for @synthesized retain properties?
  19. When should I use @synthesize explicitly?
  20. Property vs. ivar in times of ARC
  21. Custom dealloc and ARC (Objective-C)
  22. Objective C – Synthesize property [duplicate]
  23. Reason to use ivars vs properties in objective c
  24. Property ” not found on object of type ‘id’
  25. @property and @synthesize
  26. Does a private @property create an @private instance variable?
  27. Properties and Instance Variables in Objective-C
  28. What’s the purpose of an ivar when a property exists?
  29. Why do I need to write @synthesize when I provide getter and setter?
  30. Objective-C Difference between setting nil and releasing

Leave a Comment