Vector erase iterator

by

res.erase(it) always returns the next valid iterator, if you erase the last element it will point to .end()

At the end of the loop ++it is always called, so you increment .end() which is not allowed.

Simply checking for .end() still leaves a bug though, as you always skip an element on every iteration (it gets ‘incremented’ by the return from .erase(), and then again by the loop)

You probably want something like:

 while (it != res.end()) {
        it = res.erase(it);    
 }

to erase each element

(for completeness: I assume this is a simplified example, if you simply want every element gone without having to perform an operation on it (e.g. delete) you should simply call res.clear())

When you only conditionally erase elements, you probably want something like

for ( ; it != res.end(); ) {
  if (condition) {
    it = res.erase(it);
  } else {
    ++it;
  }
}

More Related Contents:

  1. How to use an iterator?
  2. iterate vector, remove certain items as I go
  3. Sorting a vector in descending order
  4. Iterating C++ vector from the end to the beginning
  5. What’s faster, iterating an STL vector with vector::iterator or with at()?
  6. How to navigate through a vector using iterators? (C++)
  7. std::vector iterator invalidation
  8. Does resizing a vector invalidate iterators?
  9. What happens if you increment an iterator that is equal to the end iterator of an STL container
  10. Erasing vector::end from vector
  11. iterator for 2d vector
  12. How to erase & delete pointers to objects stored in a vector?
  13. Invalid operands to binary expression while implementing vector [closed]
  14. Erasing elements from a vector
  15. Why can’t I make a vector of references?
  16. Does C++11 allow vector?
  17. How to implement an STL-style iterator and avoid common pitfalls?
  18. Is this behavior of vector::resize(size_type n) under C++11 and Boost.Container correct?
  19. sizeof() a vector
  20. How to cin values into a vector
  21. What is the simplest way to convert array to vector?
  22. pop_back() return value?
  23. How to implement 2D vector array?
  24. std::vector, default construction, C++11 and breaking changes
  25. How can I use something like std::vector?
  26. How to make elements of vector unique? (remove non adjacent duplicates)
  27. Does clearing a vector affect its capacity?
  28. Incrementing iterators: Is ++it more efficient than it++? [duplicate]
  29. How to create a vector of user defined size but with no predefined values?
  30. Why does using push_back on a vector declared with size result in a vector of zeros?

Leave a Comment