How to use an iterator?

by

That your code compiles at all is probably because you have a using namespace std somewhere. (Otherwise vector would have to be std::vector.) That’s something I would advise against and you have just provided a good case why:
By accident, your call picks up std::distance(), which takes two iterators and calculates the distance between them. Remove the using directive and prefix all standard library types with std:: and the compiler will tell you that you tried to pass a vector <point>::iterator where a point* was required.

To get a pointer to an object an iterator points to, you’d have to dereference the iterator – which gives a reference to the object – and take the address of the result: &*ii.
(Note that a pointer would perfectly fulfill all requirements for a std::vector iterator and some earlier implementations of the standard library indeed used pointers for that, which allowed you to treat std::vector iterators as pointers. But modern implementations use a special iterator class for that. I suppose the reason is that using a class allows overloading functions for pointers and iterators. Also, using pointers as std::vector iterators encourages mixing pointers and iterators, which will prevent the code to compile when you change your container.)

But rather than doing this, I suggest you change your function so that it takes references instead (see this answer for why that’s a good idea anyway.) : 

float distance(const point& p1, const point& p2)
{
    return sqrt((p1.x - p2.x)*(p1.x - p2.x) +
                (p1.y - p2.y)*(p1.y - p2.y));
}

Note that the points are taken by const references. This indicates to the caller that the function won’t change the points it is passed.

Then you can call it like this: distance(*ii,*jj).

On a side note, this 

typedef struct point {
    float x;
    float y;
} point;

is a C-ism unnecessary in C++. Just spell it 

struct point {
    float x;
    float y;
};

That would make problems if this struct definition ever was to parse from a C compiler (the code would have to refer to struct point then, not simply point), but I guess std::vector and the like would be far more of a challenge to a C compiler anyway.

More Related Contents:

  1. Vector erase iterator
  2. How to avoid memory leaks when using a vector of pointers to dynamically allocated objects in C++?
  3. iterate vector, remove certain items as I go
  4. Sorting a vector in descending order
  5. How are iterators and pointers related?
  6. Iterating C++ vector from the end to the beginning
  7. What’s faster, iterating an STL vector with vector::iterator or with at()?
  8. How to navigate through a vector using iterators? (C++)
  9. std::vector iterator invalidation
  10. Does resizing a vector invalidate iterators?
  11. What do I need to do before deleting elements in a vector of pointers to dynamically allocated objects?
  12. Are non dereferenced iterators past the “one past-the-end” iterator of an array undefined behavior?
  13. Can raw pointers be used instead of iterators with STL algorithms for containers with linear storage?
  14. What happens if you increment an iterator that is equal to the end iterator of an STL container
  15. Is an iterator in C++ a pointer?
  16. Erasing vector::end from vector
  17. iterator for 2d vector
  18. How to erase & delete pointers to objects stored in a vector?
  19. What happen to pointers when vectors need more memory and realocate memory?
  20. How to deal with c-string pointers [closed]
  21. Is segmentation fault actual undefined behavior when we refer to a non-static data-member
  22. Are there benefits of passing by pointer over passing by reference in C++?
  23. NULL vs nullptr (Why was it replaced?) [duplicate]
  24. What is the ‘this’ pointer?
  25. C++ delete vector, objects, free memory
  26. Why not use pointers for everything in C++?
  27. Why does a push_back on an std::list change a reverse iterator initialized with rbegin?
  28. Difference between const. pointer and reference?
  29. What is iterator invalidation?
  30. Can I call memcpy() and memmove() with “number of bytes” set to zero?

Leave a Comment