Vector Iterators Incompatible

by

The reason you are getting this, is that the iterators are from two (or more) different copies of myVec. You are returning a copy of the vector with each call to myFoo.getVec(). So the iterators are incompatible.

Some solutions:

Return a const reference to the std::vector<int> :

const std::vector<int> & getVec(){return myVec;} //other stuff omitted

Another solution, probably preferable would be to get a local copy of the vector and use this to get your iterators: 

const std::vector<int> myCopy = myFoo.getVec();
std::vector<int>::const_iterator i = myCopy.begin();
while(i != myCopy.end())
{
  //do stuff
  ++i;
}

Also +1 for not using namespace std;

More Related Contents:

  1. Erasing elements from a vector
  2. Why can’t I make a vector of references?
  3. What is the easiest way to initialize a std::vector with hardcoded elements?
  4. Concatenating two std::vectors
  5. Alternative to vector
  6. Why isn’t vector a STL container?
  7. Best way to extract a subvector from a vector?
  8. When vectors are allocated, do they use memory on the heap or the stack?
  9. reduce the capacity of an stl vector
  10. How to sum up elements of a C++ vector?
  11. How to avoid memory leaks when using a vector of pointers to dynamically allocated objects in C++?
  12. Does vector::erase() on a vector of object pointers destroy the object itself?
  13. how do you insert the value in a sorted vector?
  14. How to use std::sort with a vector of structures and compare function?
  15. Reorder vector using a vector of indices [duplicate]
  16. std::vector, default construction, C++11 and breaking changes
  17. Initial capacity of vector in C++
  18. std::vector iterator invalidation
  19. array vs vector vs list
  20. How to make elements of vector unique? (remove non adjacent duplicates)
  21. Why would I prefer using vector to deque
  22. How to downsize std::vector?
  23. C++ convert vector to vector
  24. What happens if you increment an iterator that is equal to the end iterator of an STL container
  25. Getting a vector into a function that expects a vector
  26. Can std::vector emplace_back copy construct from an element of the vector itself?
  27. STL vectors with uninitialized storage?
  28. “Right” way to deallocate an std::vector object
  29. C++ template function compiles in header but not implementation
  30. vector and const

Leave a Comment