Wait promise inside for loop

by

This will be straightforward if you can use async/await:

// Make sure that this code is inside a function declared using
// the `async` keyword.
let currentProduct;

for (let i = 0; i < products.length; i++) { 
    currentProduct = products[i];

    // By using await, the code will halt here until
    // the promise resolves, then it will go to the
    // next iteration...
    await subscription.getAll(products[i]._id)
        .then((subs) => {
            // Make sure to return your promise here...
            return update(subs, currentProduct);
        });

    // You could also avoid the .then by using two awaits:
    /*
    const subs = await subscription.getAll(products[i]._id);
    await update(subs, currentProduct);
    */
}

Or if you can only use plain promises, you can loop through all your products, and put each promise in the .then of the last loop. In that way, it will only advance to the next when the previous has resolved (even though it will have iterated the whole loop first):

let currentProduct;

let promiseChain = Promise.resolve();
for (let i = 0; i < products.length; i++) { 
    currentProduct = products[i];

    // Note that there is a scoping issue here, since
    // none of the .then code runs till the loop completes,
    // you need to pass the current value of `currentProduct`
    // into the chain manually, to avoid having its value
    // changed before the .then code accesses it.

    const makeNextPromise = (currentProduct) => () => {
        // Make sure to return your promise here.
        return subscription.getAll(products[i]._id)
            .then((subs) => {
                // Make sure to return your promise here.
                return update(subs, currentProduct);
            });
    }

    // Note that we pass the value of `currentProduct` into the
    // function to avoid it changing as the loop iterates.
    promiseChain = promiseChain.then(makeNextPromise(currentProduct))
}

In the second snippet, the loop just sets up the entire chain, but doesn’t execute the code inside the .then immediately. Your getAll functions won’t run until each prior one has resolved in turn (which is what you want).

More Related Contents:

  1. How do I convert an existing callback API to promises?
  2. When is .then(success, fail) considered an antipattern for promises?
  3. Is “.then(function(a){ return a; })” a no-op for promises?
  4. Correct way to write loops for promise.
  5. Asynchronous exception handling with bluebird promises
  6. Using async/await with a forEach loop
  7. Object method with ES6 / Bluebird promises
  8. Handling multiple catches in promise chain
  9. Limit concurrency of promise being run
  10. Can’t throw error from within an async promise executor function
  11. for await of VS Promise.all
  12. Why do I need to await an async function when it is not supposedly returning a Promise?
  13. Catching Errors in JavaScript Promises with a First Level try … catch
  14. Slowdown due to non-parallel awaiting of promises in async generators
  15. Are there still reasons to use promise libraries like Q or BlueBird now that we have ES6 promises? [closed]
  16. using async await and .then together
  17. How do I handle errors with promises?
  18. Placement of catch BEFORE and AFTER then
  19. How to promisify Node’s child_process.exec and child_process.execFile functions with Bluebird?
  20. Limit concurrency of pending promises
  21. Difference of using async / await vs promises?
  22. Why is my asynchronous function returning Promise { } instead of a value?
  23. What is the promise disposer pattern?
  24. How to wait for a JavaScript Promise to resolve before resuming function?
  25. How to async await in react render function?
  26. Using await outside of an async function
  27. Will async/await block a thread node.js
  28. javascript promise not passing all arguments (using Q)
  29. How does Bluebird’s util.toFastProperties function make an object’s properties “fast”?
  30. How to Promisify this function – nodejs [duplicate]

Leave a Comment