Warning: “format not a string literal and no format arguments”

by

Xcode is complaining because this is a security problem.

Here’s code similar to yours:

NSString *nameFormat = @"%@ %@";
NSString *firstName = @"Jon";
NSString *lastName = @"Hess %@";
NSString *name = [NSString stringWithFormat:nameFormat, firstName, lastName];
NSLog(name);

That last NSLog statement is going to be executing the equivalent of this:

NSLog(@"Jon Hess %@");

That’s going to cause NSLog to look for one more string argument, but there isn’t one. Because of the way the C language works, it’s going to pick up some random garbage pointer from the stack and try to treat it like an NSString. This will most likely crash your program. Now your strings probably don’t have %@’s in them, but some day they might. You should always use a format string with data you explicitly control as the first argument to functions that take format strings (printf, scanf, NSLog, -[NSString stringWithFormat:], …).

As Otto points out, you should probably just do something like:

NSLog(errorMsgFormat, error, [error userInfo]);

More Related Contents:

  1. How to print out the method name and line number and conditionally disable NSLog?
  2. Why does string show up in NSDictionary with quotes, but others don’t? [duplicate]
  3. Swift Function to Objective C [closed]
  4. Objective C to Swift [closed]
  5. Non repeating random numbers in Objective-C
  6. How can I reverse a NSArray in Objective-C?
  7. Hidden Features of Xcode
  8. @synthesize vs @dynamic, what are the differences?
  9. In Objective-C on iOS, what is the (style) difference between “self.foo” and “foo” when using synthesized getters?
  10. Parsing XML in Cocoa
  11. Allowing interaction with a UIView under another UIView
  12. capturing self strongly in this block is likely to lead to a retain cycle
  13. CocoaPods Errors on Project Build
  14. Determining 3G vs Edge
  15. How can I compute a SHA-2 (ideally SHA 256 or SHA 512) hash in iOS?
  16. Can I use NSURLCredentialStorage for HTTP Basic Authentication?
  17. Calculating Connection/Download Speed
  18. Creating a selector from a method name with parameters
  19. How to convert NSNumber to NSString
  20. using objc_msgSend to call a Objective C function with named arguments
  21. How to use single storyboard uiviewcontroller for multiple subclass
  22. Can I pass a block as a @selector with Objective-C?
  23. How to get substring of NSString?
  24. Mac Mountain Lion send notification from CLI app
  25. Current view controller from AppDelegate?
  26. Best way to make NSRunLoop wait for a flag to be set?
  27. Xcode Preprocessor Output
  28. Making some code only run once
  29. Simple Delegate Example?
  30. Run AppleScript from Cocoa Application

Leave a Comment