What is the explicit promise construction antipattern and how do I avoid it?

by

The deferred antipattern (now explicit-construction anti-pattern) coined by Esailija is a common anti-pattern people who are new to promises make, I’ve made it myself when I first used promises. The problem with the above code is that is fails to utilize the fact that promises chain.

Promises can chain with .then and you can return promises directly. Your code in getStuffDone can be rewritten as:

function getStuffDone(param){
    return myPromiseFn(param+1); // much nicer, right?
}

Promises are all about making asynchronous code more readable and behave like synchronous code without hiding that fact. Promises represent an abstraction over a value of one time operation, they abstract the notion of a statement or expression in a programming language.

You should only use deferred objects when you are converting an API to promises and can’t do it automatically, or when you’re writing aggregation functions that are easier expressed this way.

Quoting Esailija:

This is the most common anti-pattern. It is easy to fall into this when you don’t really understand promises and think of them as glorified event emitters or callback utility. Let’s recap: promises are about making asynchronous code retain most of the lost properties of synchronous code such as flat indentation and one exception channel.

More Related Contents:

  1. How do I tell if an object is a Promise?
  2. How to check if an object is a Promise?
  3. How do I access previous promise results in a .then() chain?
  4. Aren’t promises just callbacks?
  5. Are there still reasons to use promise libraries like Q or BlueBird now that we have ES6 promises? [closed]
  6. When would someone need to create a deferred?
  7. How to extract data out of a Promise
  8. When is .then(success, fail) considered an antipattern for promises?
  9. How to return many Promises and wait for them all before doing other stuff
  10. Resolve promises one after another (i.e. in sequence)?
  11. Cancel a vanilla ECMAScript 6 Promise chain
  12. Asynchronous exception handling with bluebird promises
  13. How to sequentially run promises with Q in Javascript?
  14. Handling multiple catches in promise chain
  15. What’s the difference between returning value or Promise.resolve from then()
  16. fetch: Reject promise with JSON error object
  17. Catching Errors in JavaScript Promises with a First Level try … catch
  18. Slowdown due to non-parallel awaiting of promises in async generators
  19. using a fetch inside another fetch in javascript
  20. How do I handle errors with promises?
  21. What is the difference between “event loop queue” and “job queue”?
  22. What are asynchronous functions in JavaScript? What is “async” and “await” in JavaScript?
  23. What is the intention behind clause 2.2.4 of Promise/A+ spec?
  24. Promises, pass additional parameters to then chain
  25. Limit concurrency of pending promises
  26. Node.js: When to use Promises vs Callbacks
  27. How can I export promise result?
  28. Why does javascript ES6 Promises continue execution after a resolve?
  29. How do you properly promisify request?
  30. Promise.resolve().then vs setImmediate vs nextTick

Leave a Comment