What’s bad about shifting a 32-bit variable 32 bits?

by

Yes, it is undefined behaviour.

ISO/IEC 9899:1999 6.5.7 Bitwise shift operators ΒΆ3

The integer promotions are performed on each of the operands. The type of the result is that of the promoted left operand. If the value of the right operand is negative or is greater than or equal to the width of the promoted left operand, the behavior is undefined.

C11 aka ISO/IEC 9899:2011 says the same.

You should first cast b to the target integer type. Another point is that you should put parentheses around the macro parameters to avoid surprises by operator precedences. Additionally, the comma operator is very useful here, allowing you to avoid the braces, so that the macro can be used as a normal command, closed with a semicolon.

#define splitup(a,b,c) ( (b) = (a) >> 32, (c) = (a) & 0xffffffff )
#define combine(a,b,c) ( (a) = ((unsigned long long)(b) << 32) | (c) )

Additional casts may be necessary for `splitup to silence warnings about precision loss by over-paranoid compilers.

#define splitup(a,b,c) ( (b) = (unsigned long)((a) >> 32), (c) = (unsigned long)((a) & 0xffffffff) )

And please don’t even think about using your self-written encryption for production code.

More Related Contents:

  1. Fast computing of log2 for 64-bit integers
  2. What is the fastest/most efficient way to find the highest set bit (msb) in an integer in C?
  3. Efficient Algorithm for Bit Reversal (from MSB->LSB to LSB->MSB) in C
  4. Arithmetic bit-shift on a signed integer
  5. Are the shift operators () arithmetic or logical in C?
  6. How can I multiply and divide using only bit shifting and adding?
  7. What is Bit Masking?
  8. What is CHAR_BIT?
  9. Find most significant bit (left-most) that is set in a bit array
  10. Extracting bits with a single multiplication
  11. Bitfield manipulation in C
  12. Fastest way to clamp a real (fixed/floating point) value?
  13. Using intptr_t instead of void*?
  14. warning: left shift count >= width of type
  15. set the m-bit to n-bit [closed]
  16. Bitshift and integer promotion?
  17. Bit twiddling: which bit is set?
  18. How to define and work with an array of bits in C?
  19. Implementing Logical Right Shift in C
  20. How do I get bit-by-bit data from an integer value in C?
  21. Algorithm to generate bit mask
  22. How does this bitwise operation check for a power of 2?
  23. Check if a number is non zero using bitwise operators in C
  24. How to replace bits in a bitfield without affecting other bits using C
  25. Decimal to Binary
  26. Why double in C is 8 bytes aligned?
  27. Bitwise shifting array of char’s
  28. How to implement Bitcount using only Bitwise operators?
  29. Order of fields when using a bit field in C
  30. What is bit masking?

Leave a Comment