Why are my struct’s members not properly initialised using `{}`? [duplicate]

by

When you write = {0}, that only explicitly initialises the first member; the rest are zero-initialised implicitly according to the standard, so it appears at first glance that you explicitly initialised all members with the 0 that you wrote, but you didn’t.

That place where you wrote 0 only affects the first member. So when, one day, you changed it to 1 thinking that it’ll change all members, you’ll have a bug, like here. It’s misleading/dangerous/silly/fragile code.

For that reason, without an accompanying explanatory comment, = {0} will not pass code review in my team. You should originally have written:

T t = {};

And now, to solve your problem according to the new requirements, you should write:

T t = {1,1,1};

or, if you don’t mind your struct potentially losing POD-ness, give T a constructor.

Formal wording

[C++11: 8.5.1/2]: When an aggregate is initialized by an initializer list, as specified in 8.5.4, the elements of the initializer list are taken as initializers for the members of the aggregate, in increasing subscript or member order. Each member is copy-initialized from the corresponding initializer-clause. If the initializer-clause is an expression and a narrowing conversion (8.5.4) is required to convert the expression, the program is ill-formed. [..]

[C++11: 8.5.1/6]: An initializer-list is ill-formed if the number of initializer-clauses exceeds the number of members or elements to initialize.

[C++11: 8.5.1/7]: If there are fewer initializer-clauses in the list than there are members in the aggregate, then each member not explicitly initialized shall be initialized from an empty initializer list (8.5.4).

More Related Contents:

  1. Do the parentheses after the type name make a difference with new?
  2. What do the following phrases mean in C++: zero-, default- and value-initialization?
  3. Why do I see strange values when I print uninitialized variables?
  4. What is the order of evaluation in a member initializer list?
  5. Why can templates only be implemented in the header file?
  6. When can I use a forward declaration?
  7. “std::endl” vs “\n”
  8. Is there a difference between copy initialization and direct initialization?
  9. What are all the common undefined behaviours that a C++ programmer should know about? [closed]
  10. What is the difference between public, private, and protected inheritance in C++?
  11. Best practices for circular shift (rotate) operations in C++
  12. What XML parser should I use in C++? [closed]
  13. Does initialization entail lvalue-to-rvalue conversion? Is `int x = x;` UB?
  14. Why doesn’t a simple “Hello World”-style program compile with Turbo C++?
  15. What are the new features in C++17?
  16. What is an undefined reference/unresolved external symbol error and how do I fix it?
  17. What are the advantages of list initialization (using curly braces)?
  18. How to get IOStream to perform better?
  19. How to initialize std::array elegantly if T is not default constructible?
  20. When are static and global variables initialized?
  21. memset() or value initialization to zero out a struct?
  22. Are function static variables thread-safe in GCC?
  23. gcc/g++: “No such file or directory”
  24. C++ where to initialize static const
  25. Why do we actually need Private or Protected inheritance in C++?
  26. What is dynamic initialization of object in c++?
  27. Initializing container of unique_ptrs from initializer list fails with GCC 4.7
  28. Value initialization and Non POD types
  29. Has the new C++11 member initialization feature at declaration made initialization lists obsolete?
  30. Member fields, order of construction

Leave a Comment