Why does foo = filter(…) return a , not a list? [duplicate]

Have a look at the python documentation for filter(function, iterable) (from here):

Construct an iterator from those elements of iterable for which function returns true.

So in order to get a list back you have to use list class:

shesaid = list(filter(greetings(), ["hello", "goodbye"]))

But this probably isn’t what you wanted, because it tries to call the result of greetings(), which is “hello”, on the values of your input list, and this won’t work. Here also the iterator type comes into play, because the results aren’t generated until you use them (for example by calling list() on it). So at first you won’t get an error, but when you try to do something with shesaid it will stop working:

>>> print(list(shesaid))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: 'str' object is not callable

If you want to check which elements in your list are equal to “hello” you have to use something like this:

shesaid = list(filter(lambda x: x == "hello", ["hello", "goodbye"]))

(I put your function into a lambda, see Randy C’s answer for a “normal” function)

Leave a Comment