Why does one often see “null != variable” instead of “variable != null” in C#?

by

It’s a hold-over from C. In C, if you either use a bad compiler or don’t have warnings turned up high enough, this will compile with no warning whatsoever (and is indeed legal code):

// Probably wrong
if (x = 5)

when you actually probably meant

if (x == 5)

You can work around this in C by doing:

if (5 == x)

A typo here will result in invalid code.

Now, in C# this is all piffle. Unless you’re comparing two Boolean values (which is rare, IME) you can write the more readable code, as an “if” statement requires a Boolean expression to start with, and the type of “x=5” is Int32, not Boolean.

I suggest that if you see this in your colleagues’ code, you educate them in the ways of modern languages, and suggest they write the more natural form in future.

More Related Contents:

  1. When do you use the “this” keyword? [closed]
  2. String output: format or concat in C#?
  3. Should I use public properties and private fields or public fields for data?
  4. Is there a downside to adding an anonymous empty delegate on event declaration?
  5. Does anyone still use [goto] in C# and if so why? [closed]
  6. Order of items in classes: Fields, Properties, Constructors, Methods
  7. Check if a string contains an element from a list (of strings)
  8. How to generically format a boolean to a Yes/No string?
  9. When to use properties instead of functions
  10. Are protected members/fields really that bad?
  11. Unique ways to use the null coalescing operator [closed]
  12. How do you test your Request.QueryString[] variables?
  13. c#: difference between “System.Object” and “object”
  14. Why does StyleCop recommend prefixing method or property calls with “this”?
  15. Best way to check for nullable bool in a condition expression (if …) [closed]
  16. Method Overloading with different return type [duplicate]
  17. (0 == variable) or (null == obj): An outdated practice in C#? [duplicate]
  18. How to clean up if else series
  19. Boiler plate code replacement – is there anything bad about this code?
  20. Disable Required validation attribute under certain circumstances
  21. string = string + int: What’s behind the scenes?
  22. Enter “&” symbol into a text Label in Windows Forms?
  23. How to pass sqlparameter to IN()? [duplicate]
  24. String escape into XML
  25. How to throttle event stream using RX?
  26. RSA Encryption, getting bad length
  27. ComboBox.SelectedText doesn’t give me the SelectedText
  28. Incompatible wire encryption levels requested on client and server with Firebird ado.net provider
  29. String.IsNullOrWhiteSpace in LINQ Expression
  30. I’ve been hacked. Evil aspx file uploaded called AspxSpy. They’re still trying. Help me trap them‼

Leave a Comment