why is -1>strlen(t) true in C? [duplicate]

by

Anyone got an idea what i’m doing wrong

strlen() returns a size_t, which is an unsigned integer type. -1 interpreted as an unsigned integer is a large value, so it ends up being greater than the length of your string. You can use the -Wsign-compare flag in gcc and some other compilers to warn you when you try to compare signed and unsigned values.

Also, it doesn’t make much sense to compare the length of a string to -1. A length can never be negative; it’s always going to be 0 or greater. So you’ll probably want to rewrite your code to test against 0, or otherwise properly implement whatever condition you’re trying to test for.

if(-1<strlen(str))
printf("The size of the string is %d", strlen(str));

In this code, you might reasonably expect the test to always succeed and the printf() to execute, since the length is always 0 or more. But you’re finding that the test actually fails and the printf() never happens because -1 is promoted to an unsigned so that it can be compared to a size_t. The easy solution is to remove the condition altogether: you know the test will always succeed, so there’s no need for it. Just remove the if*:

printf("The size of the string is %zu", strlen(str));

*Also, change the print format specifier from %d to %zu since, as Matt McNabb pointed out in a comment, you’re trying to print a size_t.

More Related Contents:

  1. Why does glibc’s strlen need to be so complicated to run quickly?
  2. How does the strlen function work internally?
  3. Sizeof vs Strlen
  4. strlen not checking for NULL
  5. "." or "->" C struct accessor [duplicate]
  6. Access of register STM32 CAN communication
  7. The most efficient way to implement an integer based power function pow(int, int)
  8. warning: implicit declaration of function
  9. What is the difference between char * const and const char *?
  10. Easy way to use variables of enum types as string in C?
  11. Map a 2D array onto a 1D array
  12. Dynamic memory access only works inside function
  13. String literals: pointer vs. char array
  14. C function pointer casting to void pointer
  15. Using strtok() in nested loops in C?
  16. __attribute__((constructor)) equivalent in VC?
  17. Building a kernel module from several source files which one of them has the same name as the module
  18. Why didn’t gcc (or glibc) implement _s functions?
  19. Is the compiler allowed to recycle freed pointer variables?
  20. How to change a variable in a calling function from a called function? [duplicate]
  21. C function defined as int but having no return statement in the body still compiles
  22. plain C: opening a directory with fopen()
  23. What’s a good C decompiler? [closed]
  24. Flexible array member not getting copied when I make a shallow copy of a struct
  25. Multiple threads and CPU cache
  26. Reading newline from previous input when reading from keyboard with scanf()
  27. How to print exact value of the program counter in C
  28. How can I read a child process’s output?
  29. CreateDesktop() with vista and UAC on (C, windows)
  30. Why does combining two shifts of a uint8_t produce a different result?

Leave a Comment