Why is adding an OnClickListener inside onBindViewHolder of a RecyclerView.Adapter considered bad practice?

by

The reason it is better to handle your click logic inside the ViewHolder is because it allows for more explicit click listeners. As expressed in the Commonsware book:

Clickable widgets, like a RatingBar, in a ListView row had long been in conflict with click events on rows themselves. Getting rows that can be clicked, with row contents that can also be clicked, gets a bit tricky at times. With RecyclerView, you are in more explicit control over how this sort of thing gets handled… because you are the one setting up all of the on-click handling logic.

By using the ViewHolder model you can gain a lot of benefits for click handling in a RecyclerView than previously in the ListView. I wrote about this in a blog post comparing the differences – https://androidessence.com/recyclerview-vs-listview

As for why it is better in the ViewHolder instead of in onBindViewHolder(), that is because onBindViewHolder() is called for each and every item and setting the click listener is an unnecessary option to repeat when you can call it once in your ViewHolder constructor. Then, if your click responds depends on the position of the item clicked, you can simply call getAdapterPosition() from within the ViewHolder. Here is another answer I’ve given that demonstrates how you can use the OnClickListener from within your ViewHolder class.

More Related Contents:

  1. Android RecyclerView Scrolling Performance
  2. Recycler view – resizing item view while scrolling (for carousel like effect)
  3. Attempt to invoke interface method ‘int java.util.List.size()’ on a null object How Solve It? [duplicate]
  4. What is Difference between Static Variable and Static method and Static Class? [duplicate]
  5. How to create RecyclerView with multiple view types
  6. RecyclerView onClick
  7. Why doesn’t RecyclerView have onItemClickListener()?
  8. How to display data from Firestore in a RecyclerView with Android?
  9. Android 5.0 – Add header/footer to a RecyclerView
  10. Android RecyclerView addition & removal of items
  11. How to add a recyclerView inside another recyclerView
  12. How to scroll to the bottom of a RecyclerView? scrollToPosition doesn’t work
  13. RecyclerView Item Click Listener the Right Way
  14. How to get a context in a recycler view adapter
  15. Map.clear() vs new Map : Which one will be better? [duplicate]
  16. RecyclerView – Get view at particular position
  17. How can I avoid garbage collection delays in Java games? (Best Practices) [closed]
  18. Android – Prevent white screen at startup
  19. Recyclerview not call onCreateViewHolder
  20. App crashing when trying to use RecyclerView on android 5.0
  21. Divide elements on groups in RecyclerView or Grouping Recyclerview items ,say by date
  22. RecyclerView not calling onCreateViewHolder or onBindView
  23. Recyclerview painfully slow to load cached images form Picasso
  24. LinearLayoutManager setReverseLayout() == true but items stack from bottom
  25. RecyclerView scrolled UP/DOWN listener
  26. How can I profile my Android app? [closed]
  27. Two ArrayList one RecyclerView Adapter
  28. How to update edittext whenever a quantity is added in android studio
  29. Is Hibernate an overkill for an Android application? [duplicate]
  30. Recyclerview not call any Adapter method :onCreateViewHolder,onBindViewHolder,

Leave a Comment