Wrapping a ByteBuffer with an InputStream

by

There seem to be some bugs with the implementation referred to by Thilo, and also copy and pasted on other sites verbatim:

  1. ByteBufferBackedInputStream.read() returns a sign extended int representation of the byte it reads, which is wrong (value should be in range [-1..255])
  2. ByteBufferBackedInputStream.read(byte[], int, int) does not return -1 when there are no bytes remaining in the buffer, as per the API spec

ByteBufferBackedOutputStream seems relatively sound.

I present a ‘fixed’ version below. If I find more bugs (or someone points them out) I’ll update it here.

Updated: removed synchronized keywords from read/write methods

InputStream

public class ByteBufferBackedInputStream extends InputStream {

    ByteBuffer buf;

    public ByteBufferBackedInputStream(ByteBuffer buf) {
        this.buf = buf;
    }

    public int read() throws IOException {
        if (!buf.hasRemaining()) {
            return -1;
        }
        return buf.get() & 0xFF;
    }

    public int read(byte[] bytes, int off, int len)
            throws IOException {
        if (!buf.hasRemaining()) {
            return -1;
        }

        len = Math.min(len, buf.remaining());
        buf.get(bytes, off, len);
        return len;
    }
}

OutputStream

public class ByteBufferBackedOutputStream extends OutputStream {
    ByteBuffer buf;

    public ByteBufferBackedOutputStream(ByteBuffer buf) {
        this.buf = buf;
    }

    public void write(int b) throws IOException {
        buf.put((byte) b);
    }

    public void write(byte[] bytes, int off, int len)
            throws IOException {
        buf.put(bytes, off, len);
    }

}

More Related Contents:

  1. ByteBuffer.allocate() vs. ByteBuffer.allocateDirect()
  2. Gets byte array from a ByteBuffer in java
  3. Java: Converting String to and from ByteBuffer and associated problems
  4. How do I read / convert an InputStream into a String in Java?
  5. How can an app use files inside the JAR for read and write?
  6. Java NIO FileChannel versus FileOutputstream performance / usefulness
  7. Read input stream twice
  8. How to clone an InputStream?
  9. Reading InputStream as UTF-8
  10. Getting the inputstream from a classpath resource (XML file)
  11. How to identify end of InputStream in java
  12. Why does InputStream#read() return an int and not a byte?
  13. Files.walk(), calculate total size
  14. What is the difference between Reader and InputStream?
  15. How to read file from ZIP using InputStream?
  16. Reading streams from java Runtime.exec
  17. Unable to read InputStream from Java Process (Runtime.getRuntime().exec() or ProcessBuilder)
  18. InputStream from a URL
  19. Getting InputStream with RestTemplate
  20. Determine the size of an InputStream
  21. Deallocating Direct Buffer Native Memory in Java for JOGL
  22. Most efficient way to create InputStream from OutputStream
  23. Reading a binary input stream into a single byte array in Java
  24. How to use multiple Scanner objects on System.in in Java?
  25. How do I convert an OutputStream to an InputStream?
  26. How to Cache InputStream for Multiple Use
  27. Avoid Java 8 Files.walk(..) termination cause of ( java.nio.file.AccessDeniedException ) [duplicate]
  28. Binary search in a sorted (memory-mapped ?) file in Java
  29. ClassLoader getResourceAsStream returns null
  30. Java NIO: What does IOException: Broken pipe mean? [duplicate]

Leave a Comment