Write file from assembly resource stream to disk

by

I’m not sure why you’re using BinaryReader/BinaryWriter at all. Personally I’d start off with a useful utility method:

public static void CopyStream(Stream input, Stream output)
{
    // Insert null checking here for production
    byte[] buffer = new byte[8192];

    int bytesRead;
    while ((bytesRead = input.Read(buffer, 0, buffer.Length)) > 0)
    {
        output.Write(buffer, 0, bytesRead);
    }
}

then call it:

using (Stream input = assembly.GetManifestResourceStream(resourceName))
using (Stream output = File.Create(path))
{
    CopyStream(input, output);
}

You can change the buffer size of course, or have it as a parameter to the method – but the main point is that this is simpler code. Is it more efficient? Nope. Are you sure you really need this code to be more efficient? Do you actually have hundreds of megabytes you need to write out to disk?

I find I rarely need code to be ultra-efficient, but I almost always need it to be simple. The sort of difference in performance that you might see between this and a “clever” approach (if one is even available) isn’t likely to be a complexity-changing effect (e.g. O(n) to O(log n)) – and that’s the type of performance gain which really can be worth chasing.

EDIT: As noted in comments, .NET 4.0 has Stream.CopyTo so you don’t need to code this up yourself.

More Related Contents:

  1. Question about terminating a thread cleanly in .NET
  2. Fast work with Bitmaps in C#
  3. How to shut down the computer from C#
  4. How do I concatenate two arrays in C#?
  5. Is it possible to compile and execute new code at runtime in .NET?
  6. ASP.NET MVC Razor pass model to layout
  7. foreach vs someList.ForEach(){}
  8. Custom Deserialization using Json.NET
  9. What’s the difference between Application.ThreadException and AppDomain.CurrentDomain.UnhandledException?
  10. MVP examples for Windows Forms
  11. Serialize a nullable int
  12. EPPlus number format
  13. How to add XmlInclude attribute dynamically
  14. IIS WCF service hosting vs Windows Service
  15. How to know the size of the string in bytes?
  16. Stream.Seek(0, SeekOrigin.Begin) or Position = 0
  17. Combine two Images into one new Image
  18. Lock-free multi-threading is for real threading experts
  19. Remove the title bar in Windows Forms
  20. XmlSerialize a custom collection with an Attribute
  21. How do I determine the true pixel size of my Monitor in .NET?
  22. Multicast delegate of type Func (with return value)?
  23. What does this C# code with an “arrow” (=>, an equal sign and greater than sign) mean and how is it called?
  24. Redirect stdout+stderr on a C# Windows service
  25. Using Linq Except not Working as I Thought
  26. What is the purpose of AsQueryable()?
  27. Reading large XML documents in .net
  28. WinForms DataGridView – databind to an object with a list property (variable number of columns)
  29. Printing from ASP.NET to a network printer
  30. Prevent from displaying of Windows Security window

Leave a Comment