yield return statement inside a using() { } block Disposes before executing

by

When you call GetAllAnimals it doesn’t actually execute any code until you enumerate the returned IEnumerable in a foreach loop.

The dataContext is being disposed as soon as the wrapper method returns, before you enumerate the IEnumerable.

The simplest solution would be to make the wrapper method an iterator as well, like this:

public static IEnumerable<Animal> GetAllAnimals() {
    using (AnimalDataContext dataContext = new AnimalDataContext()) {
        foreach (var animalName in dataContext.GetAllAnimals()) {
            yield return GetAnimal(animalName);
        }
    }
}

This way, the using statement will be compiled in the outer iterator, and it will only be disposed when the outer iterator is disposed.

Another solution would be to enumerate the IEnumerable in the wrapper. The simplest way to do that would be to return a List<Animal>, like this:

public static IEnumerable<Animal> GetAllAnimals() {
    using (AnimalDataContext dataContext = new AnimalDataContext()) {
        return new List<Animal>(dataContext.GetAllAnimals());
    }
}

Note that this loses the benefit of deferred execution, so it will get all of the animals even if you don’t need them.

More Related Contents:

  1. Do HttpClient and HttpClientHandler have to be disposed between requests?
  2. Using statement vs. IDisposable.Dispose()
  3. Questions about Entity Framework Context Lifetime
  4. Is it possible to force the use of “using” for disposable classes?
  5. Manually destroy C# objects
  6. Compression/Decompression string with C#
  7. two different DLL with same namespace
  8. Editing dictionary values in a foreach loop
  9. Convert bitmaps to one multipage TIFF image in .NET 2.0
  10. Does Stream.Dispose always call Stream.Close (and Stream.Flush)
  11. returning in the middle of a using block
  12. Determine number of pages in a PDF file [closed]
  13. How to remove an xml element from file?
  14. How to make my Windows Form app snap to screen edges?
  15. Does foreach automatically call Dispose?
  16. DataTable to JSON [duplicate]
  17. What does Process.Dispose() actually do?
  18. ClickOnce and IsolatedStorage
  19. When should I use GC.SuppressFinalize()?
  20. Can I use extension methods and LINQ in .NET 2.0 or 3.0?
  21. Combine Multiple Predicates
  22. Why would a class implement IDisposable explicitly instead of implicitly?
  23. How does the “Using” statement translate from C# to VB?
  24. Will a using block close a database connection?
  25. Do I need to Dispose a SemaphoreSlim?
  26. Who Disposes of an IDisposable public property?
  27. Determining if IDisposable should extend an interface or be implemented on a class implementing said interface
  28. Using various types in a ‘using’ statement (C#)
  29. How to get efficient Sql Server deadlock handling in C# with ADO?
  30. Best way to Bulk Insert from a C# DataTable

Leave a Comment