Cancelling a Task is throwing an exception

by

I am trying to avoid any exceptions when cancelling.

You shouldn’t do that.

Throwing OperationCanceledException is the idiomatic way that “the method you called was cancelled” is expressed in TPL. Don’t fight against that – just expect it.

It’s a good thing, because it means that when you’ve got multiple operations using the same cancellation token, you don’t need to pepper your code at every level with checks to see whether or not the method you’ve just called has actually completed normally or whether it’s returned due to cancellation. You could use CancellationToken.IsCancellationRequested everywhere, but it’ll make your code a lot less elegant in the long run.

Note that there are two pieces of code in your example which are throwing an exception – one within the task itself:

cancelToken.ThrowIfCancellationRequested()

and one where you wait for the task to complete:

task.Wait(cancellationToken.Token);

I don’t think you really want to be passing the cancellation token into the task.Wait call, to be honest… that allows other code to cancel your waiting. Given that you know you’ve just cancelled that token, it’s pointless – it’s bound to throw an exception, whether the task has actually noticed the cancellation yet or not. Options:

  • Use a different cancellation token (so that other code can cancel your wait independently)
  • Use a time-out
  • Just wait for as long as it takes

More Related Contents:

  1. What is the difference between task and thread?
  2. ThreadPool.QueueUserWorkItem vs Task.Factory.StartNew
  3. Annual calender in asp.net page [closed]
  4. Covariance and contravariance real world example
  5. Maximum number of threads in a .NET app?
  6. Is the C# static constructor thread safe?
  7. Interop type cannot be embedded
  8. How to update UI from another thread running in another class
  9. Attempted to read or write protected memory. This is often an indication that other memory is corrupt
  10. Compare using Thread.Sleep and Timer for delayed execution
  11. C# Create New T()
  12. Is it considered acceptable to not call Dispose() on a TPL Task object?
  13. Re-entrant locks in C#
  14. Getting the thread ID from a thread
  15. Multiple Parallel.ForEach loops in .Net
  16. What does SynchronizationContext do?
  17. How to put a task to sleep (or delay) in C# 4.0?
  18. Is it OK to use a string as a lock object?
  19. Proper way to Dispose of a BackGroundWorker
  20. EF Data Context – Async/Await & Multithreading
  21. Throw a NullReferenceException while calling the set_item method of a Dictionary object in a multi-threading scenario
  22. Get chrome browser title using c#
  23. C# : Monitor – Wait,Pulse,PulseAll
  24. How to use the CancellationToken without throwing/catching an exception?
  25. Should thread-safe class have a memory barrier at the end of its constructor?
  26. Read and process files in parallel C#
  27. Accessing UI in a thread
  28. ReaderWriterLock vs lock{}
  29. How to work threading with ConcurrentQueue
  30. Visual Studio 2010: How to enforce build order of projects in a solution?

Leave a Comment