Convert data type from inherited classes in C#

by

Your problem stems from the fact that the base classes are poorly designed in the first place, in the following ways:

  • The hierarchy makes no sense. A behaviour is not a special kind of position. Prefer composition to inheritance.

  • Fields should never be public. Use properties, not fields.

  • “is” checks are runtime type checks; don’t do runtime type checks for polymorphic behaviour; use virtual methods.

Let’s redesign your hierarchy.

abstract class MyBehaviour
{
    public Position Position { get; private set; }
    public Handler Handler { get; private set; }
    protected MyBehaviour(int x, int y, Handler handler) {
        this.Position = new Position(x, y);
        this.Handler = handler;
    }
}
class Behaviour1 : MyBehaviour {
  /* Whatever */
}
class Behaviour2 : MyBehaviour {
  /* Whatever */
}

All right, and now when we want to execute the handler…

 MyBehaviour b = whatever;
 b.Handler.Enter();

Done. No temporary variable needed. No runtime type check. No “if”. The behaviour provides a service; you use the service. You should not have to ask the behaviour its type in order to use the service it provides; if you do, something is probably wrong at the design level.

More Related Contents:

  1. I am finding it hard to understand inheritance in C# [closed]
  2. C# Inheritance, adding new methods [closed]
  3. What does “myBody.velocity.y” mean? [closed]
  4. How do I rotate a target object around axis A by how much a different object is rotated around axis B?
  5. Using new Unity VideoPlayer and VideoClip API to play video
  6. Saving/loading data in Unity
  7. Inheritance from multiple interfaces with the same method name
  8. C# Error: Parent does not contain a constructor that takes 0 arguments
  9. UnityWebRequest Embedding User + Password data for HTTP Basic Authentication not working on Android
  10. Fading in/out GameObject
  11. Random Numbers in Unity3D?
  12. C# – Making all derived classes call the base class constructor
  13. How to serialize and save a GameObject in Unity
  14. Why does C# null-conditional operator not work with Unity serializable variables?
  15. What’s the difference between using the Serializable attribute & implementing ISerializable?
  16. How to find inactive objects using GameObject.Find(” “) in Unity3D?
  17. Repeated serialization and deserialization creates duplicate items
  18. Pass byte array from Unity C# to C++ plugin
  19. A way of casting a base type to a derived type
  20. Camera.main is null when performing raycast
  21. Unrolled Loop works, for loop does not work [duplicate]
  22. Inheriting comments from an interface in an implementing class?
  23. Entity Framework DB-First, implement inheritance
  24. Can I Override with derived types?
  25. Convert OpenCV Mat to Texture2D?
  26. Why does this polymorphic C# code print what it does?
  27. Are private members inherited in C#?
  28. Fluent interfaces and inheritance in C#
  29. In C# 4.0, is it possible to derive a class from a generic type parameter?
  30. Adding an event handler for a control in child form from parent form in C#

Leave a Comment