Easy way find uninitialized member variables

by

If you use GCC you can use the -Weffc++ flag, which generates a warnings when a variable isn’t initialized in the member initialisation list. This:

class Foo
{
  int v;
  Foo() {}
};

Leads to:

$ g++ -c -Weffc++ foo.cpp -o foo.o
foo.cpp: In constructor ‘Foo::Foo()’:
foo.cpp:4: warning: ‘Foo::v’ should be initialized in the member initialization list

One downside is that -Weffc++ will also warn you when a variable has a proper default constructor and initialisation thus wouldn’t be necessary. It will also warn you when you initialize a variable in the constructor, but not in the member initialisation list. And it warns on many other C++ style issues, such as missing copy-constructors, so you might need to clean up your code a bit when you want to use -Weffc++ on a regular basis.

There is also a bug that causes it to always give you a warning when using anonymous unions, which you currently can’t work around other then switching off the warning, which can be done with:

#pragma GCC diagnostic ignored "-Weffc++"

Overall however I have found -Weffc++ to be incredible useful in catching lots of common C++ mistakes.

More Related Contents:

  1. Is there a difference between copy initialization and direct initialization?
  2. What is the easiest way to initialize a std::vector with hardcoded elements?
  3. Does initialization entail lvalue-to-rvalue conversion? Is `int x = x;` UB?
  4. How to emulate C array initialization “int arr[] = { e1, e2, e3, … }” behaviour with std::array?
  5. Why aren’t pointers initialized with NULL by default?
  6. How do C++ class members get initialized if I don’t do it explicitly?
  7. What are the advantages of list initialization (using curly braces)?
  8. Why do I see strange values when I print uninitialized variables?
  9. C++11 allows in-class initialization of non-static and non-const members. What changed?
  10. How to initialize std::array elegantly if T is not default constructible?
  11. When are static and global variables initialized?
  12. Why are my struct’s members not properly initialised using `{}`? [duplicate]
  13. memset() or value initialization to zero out a struct?
  14. Are function static variables thread-safe in GCC?
  15. C++ where to initialize static const
  16. What are the signs of crosses initialization?
  17. What is dynamic initialization of object in c++?
  18. C++11 member initializer list vs in-class initializer?
  19. Initializing container of unique_ptrs from initializer list fails with GCC 4.7
  20. Value initialization and Non POD types
  21. Has the new C++11 member initialization feature at declaration made initialization lists obsolete?
  22. Uses for anonymous namespaces in header files
  23. Member fields, order of construction
  24. Why must const members be initialized in the constructor initializer rather than in its body?
  25. What happens if a constructor throws an exception?
  26. Fun with uninitialized variables and compiler (GCC)
  27. What’s the motivation behind having copy and direct initialization behave differently?
  28. Why should I prefer to use member initializer lists?
  29. How do I initialize a const data member?
  30. Literal initialization for const references

Leave a Comment